Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed legend subplot #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chiaral
Copy link
Contributor

@chiaral chiaral commented Jan 11, 2021

I fixed the legend of the subplots. I hadn't realized that you had closed that PR but I think it's ok? 😬

@chiaral
Copy link
Contributor Author

chiaral commented Jan 11, 2021

it says too big of changes to view it, because the figure is in the notebook and it is read as a text string. but you can merge it.. I simply changed

# this is to give the names to the legend and put the legend outside of the plot
# create names to put in legend, if it had been one plot only (i.e. only the ensemble members) 
# I didn't need to create a list, and I could have passed data.M.values directly, but since I have to add 
# ensemble mean to the legend list, I have to create a list of values.
values_leg = [im for im in data.M.values]
values_leg.append('ensemble mean')
ax1.legend(values_leg , bbox_to_anchor = (1.1, 1))

@chiaral
Copy link
Contributor Author

chiaral commented Jan 11, 2021

Don't merge it just yet - i figured how to get the postion of the axes!
chiara

@chiaral
Copy link
Contributor Author

chiaral commented Jan 11, 2021

you can merge and close!

@chiaral
Copy link
Contributor Author

chiaral commented Feb 19, 2021

Ok you can merge this - in the next days I will open another PR for the S+L case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant