Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[testing]: mocks objectDetector functions #1045

Merged
merged 3 commits into from
Aug 22, 2020

Conversation

joeyklee
Copy link
Contributor

Dear ml5 community,

I'm making a Pull Request(PR). Please see the details below.

A good PR 🌟

β†’ Step 1: Which branch are you submitting to? 🌲

Development (for new features or updates), Release (for bug fixes), or ___________?

  • development

β†’ Step 2: Describe your Pull Request πŸ“

Fixing a Bug? Adding an Update? Submitting a New Feature? Does it introduce a breaking change?

This PR is to contribute to #637 . This is not an ideal solution since these mocks currently "test the mocks" but I'm hoping we can use this as a way of:

  1. observing how we might refactor our code to make it more easily testable and
  2. to prevent objectDetector from failing the tests due to the large size of the model

@joeyklee joeyklee added tests Label for unit testing related items. devops labels Aug 22, 2020
@joeyklee
Copy link
Contributor Author

Going to merge this in and see if this helps us.

@joeyklee joeyklee merged commit 752b23f into development Aug 22, 2020
@joeyklee joeyklee deleted the joeyklee.637-mock-functions-in-tests branch August 22, 2020 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops tests Label for unit testing related items.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant