Adding Karma + Jasmine and some other changes #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the testing framework setup to karma and jasmine instead of Jest. This removes all previous demo tests and settings for jest and replace them with karma
…ic about how to call it. Also, first test on this methods
…element in the constructor
joeyklee
pushed a commit
that referenced
this pull request
Jun 2, 2019
Adding Karma + Jasmine and some other changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #41, this replaces Jest with Karma + Jasmine.
I added just two tests and I'm currently working on adding more.
This PR also updates some changes on PoseNet and the ImageClassifier classes that simplify how they can be used.