-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NVCC Warnings #308
Merged
junrushao
merged 1 commit into
mlc-ai:mlc
from
junrushao:bugfix/2024-01-15/nvcc-warning
Jan 16, 2024
Merged
Fix NVCC Warnings #308
junrushao
merged 1 commit into
mlc-ai:mlc
from
junrushao:bugfix/2024-01-15/nvcc-warning
Jan 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junrushao
added a commit
that referenced
this pull request
Jan 16, 2024
junrushao
added a commit
that referenced
this pull request
Jan 17, 2024
junrushao
pushed a commit
that referenced
this pull request
Jan 17, 2024
junrushao
pushed a commit
to junrushao/tvm
that referenced
this pull request
Jan 17, 2024
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes: - Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return type (mlc-ai/relax#306); - Fix MSVC build warnings on not recognizing "#pragma GCC" (mlc-ai/relax#307); - Fix NVCC build warnings where it fails to infer if "[[noreturn]]" actually does not return (mlc-ai/relax#308); - Fix ROCM/Vulkan backend which fails compilation for operators like group GEMM, paged attention, etc. (apache#16404, apache#16405)
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Jan 17, 2024
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes: - Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return type (mlc-ai/relax#306); - Fix MSVC build warnings on not recognizing "#pragma GCC" (mlc-ai/relax#307); - Fix NVCC build warnings where it fails to infer if "[[noreturn]]" actually does not return (mlc-ai/relax#308); - Fix ROCM/Vulkan backend which fails compilation for operators like group GEMM, paged attention, etc. (apache#16404, apache#16405) Co-authored-by: Bohan Hou <[email protected]> Co-authored-by: Lesheng Jin <[email protected]>
junrushao
added a commit
to junrushao/tvm
that referenced
this pull request
Jan 17, 2024
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes: - Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return type (mlc-ai/relax#306); - Fix MSVC build warnings on not recognizing "#pragma GCC" (mlc-ai/relax#307); - Fix NVCC build warnings where it fails to infer if "[[noreturn]]" actually does not return (mlc-ai/relax#308); - Fix ROCM/Vulkan backend which fails compilation for operators like group GEMM, paged attention, etc. (apache#16404, apache#16405) Co-authored-by: Bohan Hou <[email protected]> Co-authored-by: Lesheng Jin <[email protected]>
junrushao
added a commit
that referenced
this pull request
Jan 17, 2024
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes: - Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return type (#306); - Fix MSVC build warnings on not recognizing "#pragma GCC" (#307); - Fix NVCC build warnings where it fails to infer if "[[noreturn]]" actually does not return (#308); - Fix ROCM/Vulkan backend which fails compilation for operators like group GEMM, paged attention, etc. (apache/tvm#16404, apache/tvm#16405) Co-authored-by: Bohan Hou <[email protected]> Co-authored-by: Lesheng Jin <[email protected]>
junrushao
added a commit
that referenced
this pull request
Jan 17, 2024
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes: - Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return type (#306); - Fix MSVC build warnings on not recognizing "#pragma GCC" (#307); - Fix NVCC build warnings where it fails to infer if "[[noreturn]]" actually does not return (#308); - Fix ROCM/Vulkan backend which fails compilation for operators like group GEMM, paged attention, etc. (apache/tvm#16404, apache/tvm#16405) Co-authored-by: Bohan Hou <[email protected]> Co-authored-by: Lesheng Jin <[email protected]>
tqchen
pushed a commit
to apache/tvm
that referenced
this pull request
Jan 17, 2024
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes: - Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return type (mlc-ai/relax#306); - Fix MSVC build warnings on not recognizing "#pragma GCC" (mlc-ai/relax#307); - Fix NVCC build warnings where it fails to infer if "[[noreturn]]" actually does not return (mlc-ai/relax#308); - Fix ROCM/Vulkan backend which fails compilation for operators like group GEMM, paged attention, etc. (#16404, #16405) Co-authored-by: Bohan Hou <[email protected]> Co-authored-by: Lesheng Jin <[email protected]>
junrushao
added a commit
that referenced
this pull request
Jan 21, 2024
This PR upstreams a few commits that recovers the unity branch from broken wheel packages. It includes the following changes: - Fix MSVC build in `pipe.h` where `DWORD` is not cast to proper return type (#306); - Fix MSVC build warnings on not recognizing "#pragma GCC" (#307); - Fix NVCC build warnings where it fails to infer if "[[noreturn]]" actually does not return (#308); - Fix ROCM/Vulkan backend which fails compilation for operators like group GEMM, paged attention, etc. (apache/tvm#16404, apache/tvm#16405) Co-authored-by: Bohan Hou <[email protected]> Co-authored-by: Lesheng Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.