-
Notifications
You must be signed in to change notification settings - Fork 88
CI updated to new python #1000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI updated to new python #1000
Conversation
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
The likely culprit is the zarr version [ref], which is probably too old for python 3.11. |
It looks like the issue resolves if you pin See here: https://github.com/grenkoca/GaNDLF/actions/runs/14536564124/job/40786016202 I'm not officially a maintainer so @scap3yvt will need to verify and merge my PR scap3yvt#7 |
Fix: Pin numcodecs<0.16.0 to resolve import error
@sarthakpati this PR is now ready (per our conversation, please disregard the MLCube workflow). |
Disregarding MLCubes entirely because of lack of support from MLCommons (last release as of writing this comment was back in 2023 [ref]). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI is getting tested upto python 3.12 but the Docker images are built using 3.11 because the docker images are older and do not have proper support for 3.12. To ensure we get proper support, the base images need to be updated, which means we need to drop CUDA 11 support for our Docker images.
No issues with this PR, good to merge.
Fixes #999
Proposed Changes
Checklist
CONTRIBUTING
guide has been followed.typing
is used to provide type hints, including and not limited to usingOptional
if a variable has a pre-defined value).pip install
step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].logging
library is being used and noprint
statements are left.