Skip to content

CI updated to new python #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
Apr 30, 2025
Merged

Conversation

scap3yvt
Copy link
Collaborator

@scap3yvt scap3yvt commented Apr 17, 2025

Fixes #999

Proposed Changes

  • all CI, docker and workflows updated to use python 3.12

Checklist

  • CONTRIBUTING guide has been followed.
  • PR is based on the current GaNDLF master .
  • Non-breaking change (does not break existing functionality): provide as many details as possible for any breaking change.
  • Function/class source code documentation added/updated (ensure typing is used to provide type hints, including and not limited to using Optional if a variable has a pre-defined value).
  • Code has been blacked for style consistency and linting.
  • If applicable, version information has been updated in GANDLF/version.py.
  • If adding a git submodule, add to list of exceptions for black styling in pyproject.toml file.
  • Usage documentation has been updated, if appropriate.
  • Tests added or modified to cover the changes; if coverage is reduced, please give explanation.
  • If customized dependency installation is required (i.e., a separate pip install step is needed for PR to be functional), please ensure it is reflected in all the files that control the CI, namely: python-test.yml, and all docker files [1,2,3].
  • The logging library is being used and no print statements are left.

@scap3yvt scap3yvt requested a review from a team as a code owner April 17, 2025 02:34
@scap3yvt scap3yvt marked this pull request as draft April 17, 2025 02:34
Copy link
Contributor

github-actions bot commented Apr 17, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sarthakpati
Copy link
Collaborator

The likely culprit is the zarr version [ref], which is probably too old for python 3.11.

grenkoca added a commit to grenkoca/GaNDLF that referenced this pull request Apr 18, 2025
@grenkoca
Copy link
Contributor

It looks like the issue resolves if you pin numcodecs<0.16.0 in setup.py

See here: https://github.com/grenkoca/GaNDLF/actions/runs/14536564124/job/40786016202

I'm not officially a maintainer so @scap3yvt will need to verify and merge my PR scap3yvt#7

@scap3yvt
Copy link
Collaborator Author

@sarthakpati this PR is now ready (per our conversation, please disregard the MLCube workflow).

@scap3yvt scap3yvt marked this pull request as ready for review April 30, 2025 18:51
@sarthakpati
Copy link
Collaborator

Disregarding MLCubes entirely because of lack of support from MLCommons (last release as of writing this comment was back in 2023 [ref]).

Copy link
Collaborator

@sarthakpati sarthakpati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI is getting tested upto python 3.12 but the Docker images are built using 3.11 because the docker images are older and do not have proper support for 3.12. To ensure we get proper support, the base images need to be updated, which means we need to drop CUDA 11 support for our Docker images.

No issues with this PR, good to merge.

@sarthakpati sarthakpati merged commit 001c927 into mlcommons:master Apr 30, 2025
24 of 25 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Upgrade all CI to python 3.11 or 3.12
3 participants