Refactor #38
Open
Refactor #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…package compatibility
Closed
xiaoyachong
reviewed
Nov 20, 2025
Contributor
xiaoyachong
left a comment
xiaoyachong
left a comment
There was a problem hiding this comment.
Thanks for your PR! It looks good. The only potential issue is that it currently has conflicts with the main branch. Could you merge main into your branch and resolve the conflicts on your side? Once that’s done, I can test it together with the other PRs.
Member
Author
|
Companion PR: mlexchange/mlex_highres_segmentation#201 |
xiaoyachong
reviewed
Nov 21, 2025
Contributor
xiaoyachong
left a comment
xiaoyachong
left a comment
There was a problem hiding this comment.
Thank you for your PR! I found a few issues with the refactor and left some comments.
Closed
This was referenced Nov 24, 2025
xiaoyachong
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion PRs:
tomo: mlexchange/mlex_tomo_framework#16
prefect worker: mlexchange/mlex_prefect_worker#26
mlex_utils: mlexchange/mlex_utils#5
highres_seg: mlexchange/mlex_highres_segmentation#201