Skip to content

default max tokens #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2025
Merged

default max tokens #128

merged 7 commits into from
Jun 5, 2025

Conversation

jmercat
Copy link
Collaborator

@jmercat jmercat commented Jun 3, 2025

As discussed in #127 the max tokens argument was passed as None if not explicitly set. This forced each benchmark initialization to make a special case for that argument and make sure it is not None.
This PR changes that:

  • it passes only not None arguments to the benchmark init function
  • init functions default are set to a number that is used in that case

@jmercat jmercat requested a review from neginraoof June 3, 2025 18:09
@neginraoof neginraoof merged commit 6cd745f into main Jun 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants