Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eval_imagenet and add eval_winoground #193

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ajtejankar
Copy link

  1. Replace .cuda() calls with .to() calls and correct device in eval_imagenet function
  2. Add eval_winoground to evaluate on the Winoground dataset

1. Replace `.cuda()` calls with `.to()` calls and correct device in `eval_imagenet` function
2. Add `eval_winoground` to evaluate on the Winoground dataset
@anas-awadalla anas-awadalla requested a review from jpgard May 17, 2023 19:00
@anas-awadalla
Copy link
Collaborator

Thanks for the contribution @ajtejankar! I assigned @jpgard, our expert on classification tasks :).

@ajtejankar
Copy link
Author

It seems the linter is failing on multiple pull requests not just mine. Do you know if it is the linter or I need to fix my pull request?

@jpgard
Copy link
Collaborator

jpgard commented May 17, 2023

Thanks for the PR @ajtejankar !

I am going to leave this for now -- we are in the middle of a large refactor of our classification code to support more tasks and fix some other bugs. Once https://github.com/mlfoundations/open_flamingo/tree/text-caching goes in, I will revisit this one.

@jpgard
Copy link
Collaborator

jpgard commented May 17, 2023

(yes, you probably need to lint your code, our linter is strict and complains a lot -- we use the black linter.)

@anas-awadalla
Copy link
Collaborator

(yes, you probably need to lint your code, our linter is strict and complains a lot -- we use the black linter.)

Can you make sure you have the latest version of black installed and then run "black ."? That should fix all formatting issues.

@ajtejankar
Copy link
Author

Sure, we can integrate this later. Also, thanks for the help with linter. For now, I will update the pull request after running black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants