Introduce OperationLike::walk #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review at your convenience @raviqqe |
raviqqe
reviewed
May 30, 2025
| } | ||
|
|
||
| /// Convenience for a pre-order walk. | ||
| fn walk_pre<F>(&self, callback: F) |
There was a problem hiding this comment.
Can we move these wrapper methods under the helpers module or remove them for now? Currently, we have a policy to have one-to-one correspondence between the Rust API and C API as much as possible in the primary API.
|
OK, thanks for the feedback. Extra wrapper methods are gone now. |
jaredhoberock
changed the title
|
Thank you for the changes! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes mlir_sys::mlirOperationWalk as OperationLike::walk, OperationLike::walk_pre, & OperationLike::walk_post
There are
#[test]s forwalk_pre&walk_postThis addresses #707