feat: support for wavelets pipe op #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebffischer
requested changes
Jun 16, 2025
| private = list( | ||
| .transform_dt = function(dt, levels) { | ||
| pars = self$param_set$get_values() | ||
| filter = pars$filter %??% "la8" |
There was a problem hiding this comment.
so this actuall a initial value, not a default?
There was a problem hiding this comment.
this is the default, I just require the value for the names, hence the nullish coalescing operator here
| tf::tf_evaluations(x), | ||
| function(x) { | ||
| wt = invoke(wavelets::dwt, X = x, .args = pars) | ||
| feats = unlist(c(wt@W, wt@V[[wt@level]]), use.names = FALSE) |
There was a problem hiding this comment.
can you comment what happens here?
There was a problem hiding this comment.
it extracts the wavelet coefficients (w@W) at all levels and concatenates the scaling coefficient (wt@V) at the specified level of wavelet decomposition
There was a problem hiding this comment.
but these are vectors? What does the t() afterwards do exactly?
There was a problem hiding this comment.
it transforms each entry into a column instead of having a single column for all entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #133
This is a port of the mlr2 implementation, see: https://github.com/mlr-org/mlr/blob/b1e2af9f4d6573aaeaa1e1f5b1bb4782a313226c/R/extractFDAFeaturesMethods.R#L126