Support added to read user and password also from file #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command line supplied values take precedence over file. Used --userfile and --pwfile (and not --passfile) in order not to break --pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
great script!
Since username and password had to be supplied via arguments to the script they showed up in command history, process lists and such. To increase security, options have been added to take these values from files instead.
Command line supplied values take precedence over values in files. So if e.g. username is supplied via --user and the new argument --userfile it will not take it from the file.
--userfile and --pwfile (and not --passfile) were used in order not to break --pass.
If you like it, feel free to pull.
Cheers!