-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix backoff inconsistency, error pages, minimal API, keepalive configurable,... #127
Open
hons82
wants to merge
19
commits into
mmatczuk:master
Choose a base branch
from
hons82:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reset is performed at the time the connection has been established. This can cause the problem described in mmatczuk#76. I the server connection fails after max_time + x it tries to reconnect. If that fails once it immediately stops trying with the message "backoff limit exceeded"
hons82
force-pushed
the
master
branch
2 times, most recently
from
May 7, 2021 12:15
4378d1f
to
bed3099
Compare
hons82
force-pushed
the
master
branch
2 times, most recently
from
May 25, 2021 13:29
338fe9a
to
2bf0d58
Compare
hons82
changed the title
Fix backoff inconsistency
Fix backoff inconsistency, error pages, minimal API, keepalive configurable,...
Aug 13, 2021
disconnect/connect within a second will be logged, but with logLevel 2 and with a single "reconnected" message
hons82
force-pushed
the
master
branch
2 times, most recently
from
October 13, 2021 13:41
51ff58a
to
e2fbec3
Compare
Time to wait before logging a disconnect can be configured
hons82
force-pushed
the
master
branch
2 times, most recently
from
October 21, 2021 15:03
94c143d
to
5ff19e7
Compare
# Conflicts: # server.go
Currently hardcoded, but might be configurable in future
file is monitored an reloaded dynamically
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reset is performed at the time the connection has been established.
This can cause the problem described in #76.
I the server connection fails after max_time + x it tries to reconnect.
If that fails once it immediately stops trying with the message "backoff limit exceeded"