-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mass update of all dependencies #171
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in some other related attempt in the past, jumping from angular 1.4.7 to 1.8.0 is HUGE ... so this would require quite a lot of effort, not sure if any of us have the cycles for that : (
I agree Carlos 😀
At the surface of it, itdoesn’t look as bad as I thought it would be
though. The first issue I’m going to look into are the Registration and
login popup boxes which are not currently popping up!
|
@@ -268,7 +269,6 @@ function app_min_css(cb) { | |||
|
|||
const vendorCssSources = [ | |||
'node_modules/bootstrap-css-only/css/bootstrap.css', | |||
'node_modules/bootstrap-css-only/css/bootstrap-theme.css', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this CSS required for @carueda ? I couldn't find it with the updated dependencies. Do you know which package it comes from?
Everything now at least installs properly. That is to say |
Bootstrap issue is described in https://stackoverflow.com/questions/52370286/npm-compilation-error-module-not-found-bootstrap-theme-css |
For the first time I've read the upgrading from AngularJS to Angular documentation... and this is pretty intimidating. It appears the guidance is to create a hybrid app (running both frameworks in parallel) before finally dropping support for the former. This is a huge undertaking and as I am not a JS developer this is beyond my capability. Likewise @carueda writing the new app Quasar/Vue is also a pretty huge undertaking at this stage... I'm thinking that we should do a Capstone project to move this forward. This is a chunk of work... |
Right, if upgrading just to a newer version of AngularJS is such a challenge, even worse to Angular, which is a different beast. About the bootstrap css stuff, I would have to look closer ... but in any case, all of that manual preparation for the minified version that was required back then when this was implemented is by now so old fashioned ... definitely better to think about a revamped version with a modern framework like Vue. Again my opinion and preference due to very happy experience with Vue in general (and Quasar for the UI framework per se). We could discuss about possible Vue components that could incrementally be added to the "orrui" prototype... |
Hi @carueda for a bit of fun I went ahead and mass updated each dependency in the package.json file. Of course this breaks quite a bit. Namely,
It looks like the
fatal error: 'errno.h' file not found
is a local environment error on my part.This looks more serious. The output is not verbose enough for me to decipher what is wrong.
I was able to launch
gulp dev
however the login and account creation windows no longer display properly.I wonder if you can try the same and report out your results?