Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configurable and precise rounding #132

Merged
merged 20 commits into from
Sep 22, 2022
Merged

Implement configurable and precise rounding #132

merged 20 commits into from
Sep 22, 2022

Conversation

mmomtchev
Copy link
Owner

This PR implements configurable and precise rounding of the results according to my proposal #128

@codecov-commenter
Copy link

Codecov Report

Base: 98.60% // Head: 98.32% // Decreases project coverage by -0.28% ⚠️

Coverage data is based on head (9c62ed8) compared to base (11162cb).
Patch coverage: 97.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #132      +/-   ##
==========================================
- Coverage   98.60%   98.32%   -0.29%     
==========================================
  Files          10       10              
  Lines        2080     2207     +127     
==========================================
+ Hits         2051     2170     +119     
- Misses         29       37       +8     
Impacted Files Coverage Δ
src/geom.js 95.19% <66.66%> (-2.62%) ⬇️
src/flight.js 95.65% <75.00%> (-0.68%) ⬇️
src/scoring.js 99.57% <99.34%> (-0.18%) ⬇️
scoring-rules.config.js 100.00% <100.00%> (ø)
src/solution.js 99.70% <100.00%> (+1.52%) ⬆️
src/solver.js 96.24% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mmomtchev mmomtchev merged commit 00dddd8 into master Sep 22, 2022
@mmomtchev mmomtchev deleted the rounding branch September 22, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants