fix: iPad landscape orientation support#2980
fix: iPad landscape orientation support#2980amanjeetsingh150 merged 4 commits intomobile-dev-inc:mainfrom
Conversation
leggomuhgreggo
force-pushed
the
fix/ipad-landscape-orientation
branch
from
aa10a91 to
0545430
Compare
leggomuhgreggo
force-pushed
the
fix/ipad-landscape-orientation
branch
4 times, most recently
from
438c8fa to
9f7768e
Compare
|
@nabs-m thanks for the review! Wanted to give a heads up — I made one additional fix after your initial approval. FWIW my team and I have been validating this change for the past couple days and everyone is saying what a joy it is to finally be able to use maestro for our project — like taking a first breath of fresh air. LMK if there's anything I can do to help facilitate integration. 🙏 |
|
@leggomuhgreggo That's great! I'm not one of the maintainers though, just happened to be looking for iPad landscape support around the same time and noticed your PR. My team is also anxious to get their hands on it, so I'd love to see this merge soon. Looking at some other PRs, seems like @Fishbowler and @amanjeetsingh150 tend to review PRs if you wanna add them to this. |
|
We're already looking :) |
Fix four bugs in the iOS XCTest runner that break landscape mode on iPad: 1. EventRecord hardcoded .portrait orientation — replaced with dynamic ScreenSizeHelper.currentInterfaceOrientation() across all 6 event synthesis call sites (touch, swipe v1/v2, text input x2, press key) 2. actualScreenSize() double-swapped dimensions — on modern iOS (13.1+), physicalScreenSize() already returns orientation-correct values; added dimsAlreadyMatchOrientation check to skip redundant swap 3. orientationAwarePoint() incorrect coordinate transform — rotation formulas assumed portrait-ordered dimensions; now uses effective dimensions (swapped width/height) when physicalScreenSize() returns landscape-correct values, ensuring correct landscape→portrait space mapping for EventRecord 4. ViewHierarchyHandler offset corruption — springboard frame (always portrait: 1024x1366) vs app frame (landscape: 1366x1024) caused a spurious (-342, +342) offset on all element positions; added isSameAreaDifferentOrientation check to skip offset when frames are the same size but different orientation Tested on iPad Air 13-inch (M3), iOS 26.2: - Portrait simulator + responsive app: 13/13 steps pass - Landscape simulator + responsive app: 13/13 steps pass - Landscape simulator + orientation-locked app: 13/13 steps pass Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Was crashing when trying to call `ScreenSizeHelper.currentInterfaceOrientation()`
leggomuhgreggo
force-pushed
the
fix/ipad-landscape-orientation
branch
from
9f7768e to
4e95c02
Compare
|
This fix is much appreciated. I'm begging for this change to be merged :) This is preventing me from utilizing Maestro for our application. I would really really like this fix ASAP. |
|
@outcomes-keyan-hardman if you're very eager, and don't mind using a duct-taped dependency, you can use the release build from my fork: |
|
@leggomuhgreggo You're a legend, thanks. |
|
@leggomuhgreggo thanks, it seems to work. But Maestro Studio goes bananas in inspect mode (when iPad simulator is in portrait mode). |
|
Any remaining blockers for this before merging it and creating a new release with it? |
|
Hey @nabs-m we would be merging this for next release. |
|
@amanjeetsingh150 is there any update on this? do you have an estimated release date? |
Doing CLI release this week, that would have this fix. |
6 participants
Summary
Fixes #2701 — iPad landscape mode causes coordinate mapping failures + element detection failures.
Problem
Maestro commands (taps, swipes, key presses, text input) fail or land on incorrect coordinates when targeting iPad apps running in landscape orientation.
The iOS XCTest driver assumes portrait orientation in several places, causing coordinate transforms and event synthesis to produce wrong results.
Solution
Identified and fixed four interrelated bugs in the iOS XCTest driver's orientation handling:
.portraitinEventRecord— Touch, swipe, and key press handlers passed.portraitby default. Now uses acurrentInterfaceOrientation()helper that correctly mapsUIDeviceOrientation→UIInterfaceOrientation(accounting for Apple's landscape inversion convention).TextInputHelperwith@MainActoractualScreenSize()— Dimensions were swapped even when the framework already returned landscape-correct values. Added adimsAlreadyMatchOrientationguard.orientationAwarePoint()transform — Coordinate mapping was wrong for landscape. Fixed the transformation logic with the same dimension-awareness guard.ViewHierarchyHandleroffset corruption — Springboard-vs-app frame mismatch in landscape introduced incorrect coordinate offsets. Added detection to skip offset adjustment when frames differ only by orientation.