Skip to content

feat: Explicit Resource Management support in reactions #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2025

Conversation

vkrol
Copy link
Contributor

@vkrol vkrol commented Jun 4, 2025

Discussion: #4559

Code change checklist

  • Added/updated unit tests
  • Updated /docs. For new functionality, at least API.md should be updated
  • Verified that there is no significant performance drop (yarn mobx test:performance)

Copy link

changeset-bot bot commented Jun 4, 2025

🦋 Changeset detected

Latest commit: d5cfb87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mobx Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vkrol vkrol marked this pull request as draft June 4, 2025 15:23
@vkrol vkrol force-pushed the support-explicit-resource-management branch 2 times, most recently from 33cd26a to 2a8bb3f Compare June 4, 2025 16:02
@vkrol vkrol force-pushed the support-explicit-resource-management branch from 2a8bb3f to d5cfb87 Compare June 4, 2025 16:05
@vkrol vkrol marked this pull request as ready for review June 4, 2025 16:10
@urugator urugator self-requested a review June 6, 2025 08:56
Copy link
Collaborator

@urugator urugator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mweststrate
Copy link
Member

This is great, thanks!

@mweststrate mweststrate merged commit fe1d3f4 into mobxjs:main Jun 15, 2025
1 check passed
@github-actions github-actions bot mentioned this pull request Jun 15, 2025
@vkrol vkrol deleted the support-explicit-resource-management branch June 15, 2025 19:50
@github-actions github-actions bot mentioned this pull request Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants