Add a Endpoint.destroy which closes active connections #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The purpose of this PR is to run the CI and build a binary we can experiment with. |
djs55
force-pushed
the
remove-connection-leak
branch
from
99d38ca to
e961686
Compare
djs55
changed the title
Previously there was no way to locate the connections associated with an endpoint to shut them down. This patch adds a map of TCP `id` to `unit Lwt.u` and a function `Endpoint.destroy` which triggers the disconnection of all the active connections. Related to moby#260 Signed-off-by: David Scott <[email protected]>
djs55
force-pushed
the
remove-connection-leak
branch
from
e961686 to
36b23db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was no way to locate the connections associated with
an endpoint to shut them down. This patch adds a map of TCP
idtounit Lwt.uand a functionEndpoint.destroywhich triggers thedisconnection of all the active connections.
Related to #260
Signed-off-by: David Scott [email protected]