fix(deps): update chokidar to v4

[ggodlewski]

PR Checklist

• Addresses an existing open issue: fixes Chore: bump chokidar to v4 #5214
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

Current chokidar is bundled with tons of spam deps including braces which trigger some audit alert.

All test are working. It supports globs unlike #5215

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: ggodlewski / name: Grzegorz Godlewski (596f18b, f72627d, 71f0276, 1647309, ca45fcf)

[JoshuaKGoldberg]

Hey thanks for getting this started! Sorry it took so long to review - since Chokidar didn't end up needing to be bumped with v11, this fell by the wayside. But I'm excited to help push this forward along now! 🚀

Requesting changes primarily on a performance point, as well as a design point. Happy to talk if you want. 🙂

[ggodlewski]

Hey @JoshuaKGoldberg, there is no way I remember the details after a month :). All I know it's been a struggle to get all tests working. In the meantime we switched to ava to resolve our issues, so I can't do much.
I updated the code to fix your issues. If there is anything that I can do fast let me know.

[talentlessguy]

@JoshuaKGoldberg is there any blocker to this PR besides merge conflicts of a lockfile?

[JoshuaKGoldberg]

Just a re-request for review. I'll add it to the queue for review :)

[JoshuaKGoldberg]

Source code looks good, thanks for the refactor!

I finally found time to really dig in and try this in production - and think I found a performance bug. LMK what you think of it.

[JoshuaKGoldberg]

🔥 This is fantastic, thanks a bunch @ggodlewski! I really appreciate you sticking through & working with me on the reviews.

I've played with this a bunch locally on relatively small and large repros, and haven't found any issues. I'd really prefer to get another review from someone on @mochajs/maintenance-crew just to be safe - but otherwise ✅ on my end.

Nice job!

[mark-wiemer]

I'll take a look at this tonight :)

[mark-wiemer]

@ggodlewski are you able to resolve the merge conflict? Otherwise looks great :)

[ggodlewski]

@mark-wiemer I rebased against main and updated lock file.