Skip to content

chore: "Force" Netlify to use npm to build new site #5319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Mar 27, 2025

Conversation

mark-wiemer
Copy link
Member

PR Checklist

Overview

"Force" Netlify to use npm instead of pnpm to get around our weird build issues.

Note this issue is only visible in Netlify so non-trusted contributors won't be able to see a lot of the context here.

Ref #5318 for links to a sample build and snippets of logs for context

@mark-wiemer mark-wiemer changed the title Build new site chore: "Force" Netlify to use npm to build new site Mar 26, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome investigation and great one-liner result, nicely done! 👏 🔥

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP or other posters - more information needed label Mar 26, 2025
@mark-wiemer mark-wiemer added status: needs review a maintainer should (re-)review this pull request and removed status: waiting for author waiting on response from OP or other posters - more information needed labels Mar 26, 2025
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3a46855 into mochajs:main Mar 27, 2025
74 of 77 checks passed
@mark-wiemer mark-wiemer deleted the build-new-site branch March 28, 2025 01:17
mark-wiemer added a commit to mark-wiemer/mocha that referenced this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review a maintainer should (re-)review this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠 Repo: New site isn't deployed to mochajs.org/next
2 participants