Skip to content

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Oct 13, 2025

Describe your changes

Pulling the proto part out of #3660

Checklists

Compatibility checklist

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.



Note

Adds WebhookConfig.ephemeral_suffix for ephemeral app URLs and clarifies requested_suffix as the user-supplied label.

  • Proto: modal_proto/api.proto
    • WebhookConfig:
      • Add string ephemeral_suffix = 11 for additional URL suffix in ephemeral Apps.
      • Document requested_suffix as the user-supplied label component of the URL.

Written by Cursor Bugbot for commit a303619. This will update automatically on new commits. Configure here.

@mwaskom mwaskom requested a review from freider October 13, 2025 13:14
@mwaskom
Copy link
Contributor Author

mwaskom commented Oct 13, 2025

Was approved as part of #3660

@mwaskom
Copy link
Contributor Author

mwaskom commented Oct 13, 2025

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @freider will follow-up review this.

@mwaskom mwaskom merged commit ced89f4 into main Oct 13, 2025
28 checks passed
@mwaskom mwaskom deleted the michael/2025-10-13-serve-dev-suffix-proto branch October 13, 2025 14:01
@freider
Copy link
Contributor

freider commented Oct 13, 2025

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants