Open
Conversation
These tests verify that print() output from markdown code blocks is properly captured by pytest rather than leaking to stdout.
The MarkdownInlinePythonItem.runtest() method was using capman.global_and_fixture_disabled(), which disables pytest's capture. The comment claimed it "ensures capture works" but the API does the opposite. This caused all print() output from markdown code examples to leak to stdout during test runs. Pytest captures stdout by default, so no special handling is needed.
Verifies that pytest's capsys fixture works correctly in markdown code blocks. This test fails on the buggy code because global_and_fixture_disabled() also disabled fixture-level capture.
Collaborator
|
Thanks! I don't remember the exact circumstances for why the capture disabling was added, but I think it might have been the opposite issue - something along the lines of output not getting printed out when using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's my attempt to fix #54. I've added three tests that all fail on 0.9 but work now.
Disclosure:
I'm no expert on pytest and how this works, it's just an attempt to find a solution and provide it with the help of Claude