Skip to content

Add context to complete requests #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

Add context to complete requests #488

merged 1 commit into from
Jun 6, 2025
+26 −1

Conversation

stephentoub
Copy link
Contributor

halter73
halter73 approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any tests for completions yet? It'd be nice to verify that the client and server can use these.

@stephentoub
Copy link
Contributor Author

Do we have any tests for completions yet? It'd be nice to verify that the client and server can use these.

I don't think we have any... we should add some.

We should probably also think about how to make it easier to write completion handlers for prompts/resources written using attributes.

@stephentoub stephentoub merged commit 46d25b7 into modelcontextprotocol:main Jun 6, 2025
7 checks passed
@stephentoub stephentoub deleted the completecontext branch June 6, 2025 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephentoub @halter73