Fix non-OK HTTP POST responses handling #374
Conversation
Currently, JDK HttpClient SSE implementation incorrectly handles a non-2xx HTTP response code for POST. Instead of immediately failing the caller, it ignores the issue and the user awaits until the timeout kicks in. A related problem happened with the WebClient Streamable HTTP implementation, where the error was swallowed for non-400 responses. Signed-off-by: Dariusz Jędrzejczyk <[email protected]>
|
@tzolov I noticed this change fails some cases of Also, I noticed the I'll leave this in a draft state for you to investigate. |
|
@chemicL , I fixed the tests. The 400 was due to the HTTP version. |
- Set HttpClient to use HTTP/1.1 version explicitly - Add Content-Type: application/json header to HttpRequest builder - Update TestHttpClientSseClientTransport constructor in test class
tzolov
force-pushed
the
http-clients-fix-post-error-handling
branch
from
bd5699f to
5313dd1
Compare
Currently, JDK HttpClient SSE implementation incorrectly handles a non-2xx HTTP response code for POST. Instead of immediately failing the caller, it ignores the issue and the user awaits until the timeout kicks in. Set HttpClient to use HTTP/1.1 version explicitly for tests A related problem happened with the WebClient Streamable HTTP implementation, where the error was swallowed for non-400 responses. Signed-off-by: Dariusz Jędrzejczyk <[email protected]>
|
Rebased, squashed and merged at 95df67e |
Currently, JDK HttpClient SSE implementation incorrectly handles a non-2xx HTTP response code for POST. Instead of immediately failing the caller, it ignores the issue and the user awaits until the timeout kicks in.
A related problem happened with the WebClient Streamable HTTP implementation, where the error was swallowed for non-400 responses.