don't coerce to ndarray when initializing/expanding arrays #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltamarnix
reviewed
Apr 4, 2025
Comment on lines
+320
to
+323
| try: | ||
| shp = value.shape # type: ignore | ||
| except AttributeError: | ||
| return np.full(shape, value) |
There was a problem hiding this comment.
exceptions can be expensive. Perhaps check with hasattr instead?
There was a problem hiding this comment.
Good point, I found this
https://stackoverflow.com/a/903238
Sounds like if value has a shape then try/except is faster but if not, it's slower. I'm not sure what proportion of arrays vs scalars we can expect. The difference isn't huge in either case but maybe worth our own benchmark at some point.
| return np.full(shape, value.item()) # type: ignore | ||
| if shp != shape: | ||
| raise ValueError(f"Shape mismatch, got {shp}, expected {shape}") | ||
| # any way to avoid the cast? |
There was a problem hiding this comment.
Casting gets optimized away by python and doesn't do anything at all. It's a pass-through function.
There was a problem hiding this comment.
yeah, I just wonder if there's any way to write this so mypy is happy without the cast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
might fix #9 ?