fix(rsbuild-plugin): failed to load remote modules with server.base (…

…#3102)
module-federation · Oct 22, 2024 · 3ac3fc8 · 3ac3fc8
1 parent b29c403
commit 3ac3fc8
Show file tree

Hide file tree

Showing 10 changed files with 421 additions and 312 deletions.
diff --git a/apps/router-demo/router-host-2000/package.json b/apps/router-demo/router-host-2000/package.json
@@ -18,7 +18,7 @@
   },
   "devDependencies": {
     "@module-federation/rsbuild-plugin": "workspace:*",
-    "@rsbuild/core": "^1.0.7",
+    "@rsbuild/core": "^1.0.16",
     "@rsbuild/plugin-react": "^1.0.3",
     "@types/react": "^18.2.79",
     "@types/react-dom": "^18.3.0",

diff --git a/apps/router-demo/router-host-v5-2200/package.json b/apps/router-demo/router-host-v5-2200/package.json
@@ -19,7 +19,7 @@
   },
   "devDependencies": {
     "@module-federation/rsbuild-plugin": "workspace:*",
-    "@rsbuild/core": "^1.0.7",
+    "@rsbuild/core": "^1.0.16",
     "@rsbuild/plugin-react": "^1.0.3",
     "@types/react": "^18.2.79",
     "@types/react-dom": "^18.3.0",

diff --git a/apps/router-demo/router-host-vue3-2100/package.json b/apps/router-demo/router-host-vue3-2100/package.json
@@ -15,7 +15,7 @@
   },
   "devDependencies": {
     "@module-federation/rsbuild-plugin": "workspace:*",
-    "@rsbuild/core": "^1.0.7",
+    "@rsbuild/core": "^1.0.16",
     "@rsbuild/plugin-vue": "^1.0.1",
     "tailwindcss": "^3.4.3",
     "typescript": "^5.4.2"

diff --git a/apps/router-demo/router-remote1-2001/package.json b/apps/router-demo/router-remote1-2001/package.json
@@ -18,7 +18,7 @@
   },
   "devDependencies": {
     "@ant-design/cssinjs": "^1.20.0",
-    "@rsbuild/core": "^1.0.7",
+    "@rsbuild/core": "^1.0.16",
     "@rsbuild/plugin-react": "^1.0.3",
     "@rsbuild/shared": "^0.7.10",
     "@types/react": "^18.2.79",

diff --git a/apps/router-demo/router-remote2-2002/package.json b/apps/router-demo/router-remote2-2002/package.json
@@ -17,7 +17,7 @@
     "react-router-dom": "6.24.1"
   },
   "devDependencies": {
-    "@rsbuild/core": "^1.0.7",
+    "@rsbuild/core": "^1.0.16",
     "@rsbuild/plugin-react": "^1.0.3",
     "@types/react": "^18.2.79",
     "@types/react-dom": "^18.3.0",

diff --git a/apps/router-demo/router-remote3-2003/package.json b/apps/router-demo/router-remote3-2003/package.json
@@ -14,7 +14,7 @@
     "vue-router": "^4.3.2"
   },
   "devDependencies": {
-    "@rsbuild/core": "^1.0.7",
+    "@rsbuild/core": "^1.0.16",
     "@rsbuild/plugin-vue": "^1.0.1",
     "@vue/tsconfig": "^0.5.1",
     "tailwindcss": "^3.4.3",

diff --git a/apps/router-demo/router-remote4-2004/package.json b/apps/router-demo/router-remote4-2004/package.json
@@ -17,7 +17,7 @@
     "react-router-dom": "6.24.1"
   },
   "devDependencies": {
-    "@rsbuild/core": "^1.0.7",
+    "@rsbuild/core": "^1.0.16",
     "@rsbuild/plugin-react": "^1.0.3",
     "@types/react": "^18.2.79",
     "@types/react-dom": "^18.3.0",

diff --git a/packages/rsbuild-plugin/package.json b/packages/rsbuild-plugin/package.json
@@ -35,7 +35,7 @@
     "@module-federation/sdk": "workspace:*"
   },
   "devDependencies": {
-    "@rsbuild/core": "1.x"
+    "@rsbuild/core": "^1.0.16"
   },
   "peerDependencies": {
     "@rsbuild/core": "1.x",

diff --git a/packages/rsbuild-plugin/src/cli/index.ts b/packages/rsbuild-plugin/src/cli/index.ts
@@ -60,7 +60,7 @@ export const pluginModuleFederation = (
         const originalConfig = api.getRsbuildConfig('original');
         if (
           originalConfig.dev?.assetPrefix === undefined &&
-          config.dev.assetPrefix === DEFAULT_ASSET_PREFIX
+          config.dev.assetPrefix === config.server?.base
         ) {
           config.dev.assetPrefix = true;
         }