- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 301
fix(sdk): issue where duplicate links were created when existing #3707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ScriptedAlchemy
wants to merge
7
commits into
main
Choose a base branch
from
duplicate-link
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+683
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s had no rel attribute
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # package.json
211a3cb
to
6a5a8dc
Compare
🦋 Changeset detectedLatest commit: ff4685d The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6a5a8dc
to
45a9a3f
Compare
45a9a3f
to
ff4685d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue in the
@module-federation/sdk
package where duplicate links were created when existing links had norel
attribute. It includes changes to thecreateLink
function and adds a corresponding test to ensure the fix works correctly. Additionally, thechangegen
script inpackage.json
has been updated to include thesdk
package.Bug Fixes and Tests:
.changeset/ai-eager-mouse.md
: Documented the fix for the issue with duplicate links and added a test indom.spec.ts
to ensure links withoutrel
attribute aren't duplicated.packages/sdk/src/dom.ts
: Modified thecreateLink
function to treatnull
andundefined
rel
attributes as equivalent when checking for existing links.packages/sdk/__tests__/dom.spec.ts
: Added a test to ensure that a duplicate link is not created when an existing link has norel
attribute and the new link'srel
attribute isundefined
.Build and Configuration:
package.json
: Updated thechangegen
script to include thesdk
package.Related Issue
#3705
Types of changes
Checklist