fix(sdk): issue where duplicate links were created when existing#3707
Closed
ScriptedAlchemy wants to merge 7 commits intomainfrom
Closed
fix(sdk): issue where duplicate links were created when existing#3707ScriptedAlchemy wants to merge 7 commits intomainfrom
ScriptedAlchemy wants to merge 7 commits intomainfrom
Conversation
…s had no rel attribute
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
# Conflicts: # package.json
211a3cb to
6a5a8dc
Compare
🦋 Changeset detectedLatest commit: ff4685d The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6a5a8dc to
45a9a3f
Compare
45a9a3f to
ff4685d
Compare
Contributor
|
Stale pull request message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue in the
@module-federation/sdkpackage where duplicate links were created when existing links had norelattribute. It includes changes to thecreateLinkfunction and adds a corresponding test to ensure the fix works correctly. Additionally, thechangegenscript inpackage.jsonhas been updated to include thesdkpackage.Bug Fixes and Tests:
.changeset/ai-eager-mouse.md: Documented the fix for the issue with duplicate links and added a test indom.spec.tsto ensure links withoutrelattribute aren't duplicated.packages/sdk/src/dom.ts: Modified thecreateLinkfunction to treatnullandundefinedrelattributes as equivalent when checking for existing links.packages/sdk/__tests__/dom.spec.ts: Added a test to ensure that a duplicate link is not created when an existing link has norelattribute and the new link'srelattribute isundefined.Build and Configuration:
package.json: Updated thechangegenscript to include thesdkpackage.Related Issue
#3705
Types of changes
Checklist