-
Notifications
You must be signed in to change notification settings - Fork 5
Dev Container development workflow #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
GondekNP
wants to merge
41
commits into
moiexpositoalonsolab:master
Choose a base branch
from
SchmidtDSE:feat/devcontainer
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev Container development workflow #6
GondekNP
wants to merge
41
commits into
moiexpositoalonsolab:master
from
SchmidtDSE:feat/devcontainer
+300
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pip install -e . to get deps as if installed interactively
…issue with torch being not present, seemingly not suing the conda env itself
… deal with bashrc issues and avoid any hackery
… deal with bashrc issues and avoid any hackery
Author
|
Also, if it's helpful, this branch (or another) could handle #2 as well :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fork is essentially attempting to run the DeepBiosphere model top to bottom, but within a Dev Container for reproducibility and ease of development's sake!
As of now, these are the only changes:
Rather than run everything in the local env, I added most of the README getting started steps (system dependencies, python dependencies, directory structure, gbif auth) into
dev.Dockerfile. Assuming that you haveDockerinstalled locally alongside VSCode with theDev Containersextension, you can runDev Containers: Reopen in Containerto build and run the development image and connect to it via SSH with VSCode. Alongside this, within the.devcontainerfolder, there are a couple other files - (1)devcontainer.jsonwhich essentially helps VSCode connect to that built container and provides some customization options, and (2)environment.ymlwhich is a conda environment file that theDockerbuild script uses to get the proper version of Python pre-installed, along with its packages (inplace-abn, shapely, pygeos, etc).I've added VSCode launch configs to
.vscodeto step thru and testDownload_GBIF_Data.pyandBuild_Data.py(as well asInference.pybut I haven't tried that one yet - related to Out-of-the-box inference without training? #5 ). Unfortunately the args to the CLI calls within the launch json are hardcoded, since I can't find any way to use vars in the actual launch json itself, but the structure is easily modifiable!To cut down on the size of my GBIF call, I added an additional flag to the CLI call for
Build_Data, which optionally passes a WKT geometry rather than an area string. This allows me to use a very small demo area within the Mojave for dev purposes. Alongside that, I changed a couple of var names for internal consistency, but no changes to functionality there.Lastly, added a local
.envwithin the repo itself to hold my local paths to relevant inputs / outputs. It looks like this:This gets called in my fork by
Utils.py, such that my local development doesn't cause any merge conflicts one day!