feat(linter) Upgrade linter #1231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tetrergeru
reviewed
Sep 12, 2025
| // @param triggerID path string true "Trigger ID" default(bcba82f5-48cf-44c0-b7d6-e1d32c64a88c) | ||
| // @param validate query bool false "For validating targets" | ||
| // @param body body dto.Trigger true "Trigger data" | ||
| // @param trigger body dto.Trigger true "Trigger data" |
Member
There was a problem hiding this comment.
А почему так форматирование поменялось? Как будто dtop должно быть с другими dto выравнено
Tetrergeru
reviewed
Sep 12, 2025
| } | ||
|
|
||
| defer func(t *testing.T) { | ||
| t.Helper() |
Member
Author
There was a problem hiding this comment.
говорит, что это функция-помощник в тестах
Tetrergeru
reviewed
Sep 12, 2025
| No, no, no, no, no, no, no | ||
| (Oh mamma mia, mamma mia) Mamma mia, let me go | ||
| Beelzebub has a devil put aside for me, for me, for me!`, | ||
| content: "30: Easy come, easy go, will you let me go?\n\t\t\t\tBismillah! No, we will not let you go\n\t\t\t\t(Let him go!) Bismillah! We will not let you go\n\t\t\t\t(Let him go!) Bismillah! We will not let you go\n\t\t\t\t(Let me go) Will not let you go\n\t\t\t\t(Let me go) Will not let you go\n\t\t\t\t(Let me go) Ah\n\t\t\t\tNo, no, no\n\t\t\t\t(Oh mamma mia, mamma mia) Mamma mia, let me go\n\t\t\t\tBeelzebub has a devil put aside for me, for me, for me!", |
Member
There was a problem hiding this comment.
Было красиво, стало по-уродски
Tetrergeru
reviewed
Sep 12, 2025
| if deltaThresholds > thresholdGapCoefficient*deltaLimits { | ||
| //// there is enough place to draw both of ERROR and WARN thresholds | ||
| thresholds = append(thresholds, newThreshold( | ||
| = append(thresholds, newThreshold( |
Member
There was a problem hiding this comment.
А почему у нас закомментированный кусок кода тут вообще, может есть смысл снести или снести с комментарием?
Member
Author
There was a problem hiding this comment.
издержки запуска с --fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Upgrade linter