Skip to content

Consistent mypy version #2695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented May 14, 2025

Explicitly aligning the version of mypy specified in config + used in github actions, to make it easier to get results consistent with those locally.

Results will vary between different python minor versions. Pinning this version makes it easier to align with the version running in CI, and means that it easier to avoid accidentally introducing typing features not available until newer python versions. 3.10 seems a reasonable minimum, ahead of 3.9's retirement later in the year.

@ADBond ADBond merged commit 60aad50 into moj-analytical-services:master May 14, 2025
28 checks passed
@ADBond ADBond deleted the maint/mypy-consistent-version branch May 14, 2025 10:08
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@7162e9d). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #2695   +/-   ##
=========================================
  Coverage          ?   80.78%           
=========================================
  Files             ?      106           
  Lines             ?     8982           
  Branches          ?        0           
=========================================
  Hits              ?     7256           
  Misses            ?     1726           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants