feat(ime-306): fix experience api crashing issue #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ujjwal-Izyane
commented
Jan 7, 2025
Ujjwal-Izyane
commented
- Stores fspiop payload to the cache
- Convert iso payload to fspiop before storing to cache for OutboundTransfersModel and InboundTransfersModel
- Update yarn.lock
- Update audit-ci.jsonc
- Update package.json
Co-authored-by: v3-Panwar-Ujjwal <[email protected]>
* chore: add log statements for debugging * ime-392:save the cache in fspiop form for payer side * ime-392:save the cache in fspiop form for inboundModel * ime-392:remove unused logs and variables * ime-406: stringify json payload for the experience api * Update advisories * ime-465: remove json stringify from sdk before caching * chore: update package versions * chore: update yarn.lock --------- Co-authored-by: v3-Panwar-Ujjwal <[email protected]> Co-authored-by: Nguni Phakela <[email protected]>
Ujjwal-Izyane
requested review from
mdebarros,
elnyry-sam-k,
vijayg10 and
kleyow
as code owners
|
@Ujjwal-Izyane is this ready for review? Can you resolve the conflicts and ping me when ready. |
|
@kleyow I have fixed the merge conflicts. |
|
kleyow
approved these changes
Jan 14, 2025
|
approved. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.