converted Mojo::DOM tests to using subtests #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR needs to be rebased on master. |
rabbiveesh
force-pushed
the
subtest-convert
branch
from
1ac6e51 to
c61f084
Compare
kraih
reviewed
May 22, 2020
rabbiveesh
force-pushed
the
subtest-convert
branch
2 times, most recently
from
4210856 to
2cfaba1
Compare
kraih
requested changes
May 22, 2020
|
Looks good to me once it has been tidyed. |
rabbiveesh
force-pushed
the
subtest-convert
branch
from
2cfaba1 to
519d056
Compare
|
okay, i tidied it. Was I not supposed to forcepush it? |
kraih
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I converted the tests for Mojo::DOM to using subtests.
Motivation
I saw on IRC that we're planning on converting all tests to using subtests, and I wanted to give back a little (you guys literally make my livelihood).
References
This addresses issue #1520. I hope to be able to do more in the future, too.