Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add legacy mode to jaeger tracing exporter to support 128bit trace ids #1314

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Jank1310
Copy link

@Jank1310 Jank1310 commented Jan 6, 2025

…32 digits) trace ids

πŸ“ Description

Add support for the 128bit trace ids to be compatible with opentelemetry

Trace context: https://www.w3.org/TR/trace-context/#trace-id
Jaeger FAQ: https://www.jaegertracing.io/docs/2.0/faq/

🎯 Relevant issues

#1311

πŸ’Ž Type of change

  • This change requires a documentation update

πŸ“œ Example code

tracing: {
  enabled: true,
  exporter: {
    type: "Jaeger",
    options: {
    legacyMode: false
    }
  }
}

🚦 How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Unit Tests
  • Manual test with local otel collector:

Output from otel debug exporter

Span #1
    Trace ID       : adf6f571b8324c6eb6f65b64b4562450
    Parent ID      :
    ID             : adf6f571b8324c6e
    Name           : action 'math.add'
    Kind           : Server
    Start time     : 2025-01-06 15:28:15.496 +0000 UTC
    End time       : 2025-01-06 15:28:15.496943 +0000 UTC
    Status code    : Unset
    Status message :

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@Jank1310 Jank1310 changed the title chore: add legacy mode to jaeger tracing exporter to support 128bit (… add legacy mode to jaeger tracing exporter to support 128bit trace ids Jan 6, 2025
Copy link

pkg-pr-new bot commented Jan 6, 2025

Open in Stackblitz

npm i https://pkg.pr.new/moleculerjs/moleculer@1314

commit: a1419d8

@Jank1310
Copy link
Author

Jank1310 commented Jan 9, 2025

@icebob Any idea ho to fix the pipeline?

@icebob
Copy link
Member

icebob commented Jan 9, 2025

I have no idea, the memwatch dep can't build itself on older Node versions. But it's not a mandatory dependency, I'm removing it...

@icebob
Copy link
Member

icebob commented Jan 9, 2025

I've fixed it in the master workflows, could you pull the commits from master into your fork, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants