Skip to content

Fix router memoization #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 27, 2025
Merged

Fix router memoization #532

merged 3 commits into from
May 27, 2025

Conversation

@ostapch
Copy link
Contributor

@ostapch ostapch commented May 23, 2025

Fix for the issue

Review PR in StackBlitz Submitted with StackBlitz.

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@molefrog
Copy link
Owner

Cool, thanks! Could you also add a short test case that reproduces the bug?

@ostapch
Copy link
Contributor Author

ostapch commented May 27, 2025

@molefrog check pls :)

@ostapch ostapch force-pushed the ostapch/patch-26 branch from 4e53587 to 9eed0dc Compare May 27, 2025 15:05
@ostapch ostapch force-pushed the ostapch/patch-26 branch from 9eed0dc to 7475a4d Compare May 27, 2025 15:15
molefrog
molefrog approved these changes May 27, 2025
View reviewed changes
Copy link
Owner

@molefrog molefrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@molefrog molefrog merged commit 1383371 into molefrog:v3 May 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@molefrog molefrog molefrog approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ostapch @molefrog