build: use pnpm to have more modern build system for the apps #5024
Conversation
…or the apps ecosystem
|
e2e tests probably have to do with slow test server, might clear up next week |
mswertz
changed the title
mswertz
changed the title
There was a problem hiding this comment.
the 'ui' app does not seem to get generated ( or copied ? )
goto: https://preview-emx2-pr-5024.dev.molgenis.org/apps/ui/ this returns a "File not found: /apps/ui/" same when running locally using gradle
mswertz
changed the title
|
fixed |
|
@connoratrug removed 'nx' again, got so many issues with caching. So this only updates to pnpm |
There was a problem hiding this comment.
what are all these svg changes ?
i don't think the failing logo test are flakey in this pr , there are failing, because they detect a regression error , please update with master , the move to nuxt .17 includes a different way of loading the logo svg data |
| : undefined, | ||
| }, | ||
| ]); | ||
| const items = computed(() => { |
| file("${projectDir}/pnpm-workspace.yaml") | ||
| ); | ||
| outputs.files(file("${projectDir}/pnpm-lock.yaml")) | ||
| args = ['install'] |
There was a problem hiding this comment.
yarn needed the frozen-lock-file ( the plugin added this flag by default ), does pmpm respect the lock file by default ( as it should imo)
| @@ -10,7 +10,6 @@ | |||
| "test-ci": "vitest run", | |||
| "e2e": "playwright test", | |||
| "dev": "nuxt dev", | |||
| "generate": "nuxt generate", | |||
There was a problem hiding this comment.
we dont use it for the catalogue , but why the removal ? is it triggered ? does it fail ?
There was a problem hiding this comment.
why the diffs , i dont get it
changes:
how to test:
./gradlew runNote: also tried to add 'nx' but couldn't get caching etc right.