Skip to content

data(RD3): Improve measurements table #5050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 5, 2025

Conversation

willemijn-oudijk
Copy link
Contributor

@willemijn-oudijk willemijn-oudijk commented May 13, 2025

What are the main changes you did

This PR addresses the improvements on the measurements table as suggested in Epic #1084.

How to test

  • Go to the preview and sign in as admin
  • Create a new schema using the PATIENT_REGISTRY template and load demo data
  • When the schema has been created, go to the measurements table.
  • Enter a new individual and see that variable is required. Additionally you can check if you can enter another measurement for the same individual with the same code.
  • Find a term from EDAM, that is not from 'omics' (omics was solely included in the code ontology).
  • See if this term is an option for code.

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation
  • adjust demo data (if necessary)

@willemijn-oudijk willemijn-oudijk self-assigned this May 13, 2025
@willemijn-oudijk willemijn-oudijk changed the title data(RD3): Improve measurements table data(RD3): Improve measurements table [waiting on multi-parent ontologies] May 19, 2025
@willemijn-oudijk willemijn-oudijk changed the title data(RD3): Improve measurements table [waiting on multi-parent ontologies] data(RD3): Improve measurements table Jun 3, 2025
@davidruvolo51 davidruvolo51 marked this pull request as ready for review June 5, 2025 09:11
Copy link

sonarqubecloud bot commented Jun 5, 2025

@willemijn-oudijk willemijn-oudijk merged commit d800f5a into master Jun 5, 2025
7 checks passed
@willemijn-oudijk willemijn-oudijk deleted the data/improve_measurements branch June 5, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants