-
Notifications
You must be signed in to change notification settings - Fork 21
fix(datamodel): restructured genomic variants and interpretations tables #5088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Wait for #5095 before merging |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I just added one comment.
data/_demodata/applications/patient_registry/Genomic variants.csv
Outdated
Show resolved
Hide resolved
data/_demodata/applications/patient_registry/Variant interpretation analyses.csv
Outdated
Show resolved
Hide resolved
data/_demodata/applications/patient_registry/Variant interpretations.csv
Outdated
Show resolved
Hide resolved
Genomic variants,,,,,,,,,,,http://purl.obolibrary.org/obo/NCIT_C17248,Beacon v2 GenomicVariation see also https://www.ga4gh.org/product/categorical-variation-catvar/,Patient registry | ||
Genomic variants,,id,string,1,TRUE,,,,,,"http://purl.obolibrary.org/obo/NCIT_C164813,bc2:variantInternalId",A unique identifier maintained by an authoritative database that represents a genetic variation. E.g. 20:2447955..2447958c>g,Patient registry | ||
Genomic variants,,alternative ids,string_array,,,,,,,,http://purl.obolibrary.org/obo/NCIT_C90353,A backup sequence of characters used to identify an entity,Patient registry | ||
Genomic variants,,variant status,ontology,,,CatalogueOntologies,Status,,,,http://semanticscience.org/resource/SIO_000033,"An characterisation of the variant that indicates the state or progress (e.g., confirmed, to be verified, etc.)",Patient registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment above. Still not sure if this is genius or strange. Maybe we should go with genius, but then we need some evidence linked from either inside (a variant interpretation refback) or external (e.g. a URI to clinvar)
What are the main changes you did
This PR is part of molgenis/GCC#1084.
Variant interpretations
How to test
PATIENT_REGISTRY
template and load the demo dataVariant interpretations
,Interpretation consensus
,Variant interpretation analyses
Checklist