Skip to content

feat(tw): add generalised input switch component #5205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

davidruvolo51
Copy link
Contributor

@davidruvolo51 davidruvolo51 commented Jul 8, 2025

What are the main changes you did

This PR is part of molgenis/GCC#279

  • Created switch component that renders a list of values and icons
  • Added support for light/dark themes

Note

I attempted to generalize the "slider" that appears on hover/focus states, but I couldn't figure out a good solution that made sense with tailwind that did not break good accessibility and semantic practices. I would recommend that we implement minimal state-based styling as we run the risk of having an overload of styles that conflict with each other.

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@davidruvolo51 davidruvolo51 self-assigned this Jul 8, 2025
@davidruvolo51 davidruvolo51 marked this pull request as ready for review July 9, 2025 13:38
@davidruvolo51
Copy link
Contributor Author

This component is needed for #5236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant