Skip to content

feat(catalogue): enable access to platform via path /cms #5226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

mswertz
Copy link
Member

@mswertz mswertz commented Jul 15, 2025

Demo:

  • should be able to navigate to schemas and tables on /cms while having catalogue serve on /

to test:

Notes:

  • had to undo package.json changes for redirect because we need relative paths, will require us to be more strict in URLs and paths (particularly nasty with the menu but it is more precise)
  • had to create a proxy config in catalogue for '/cms' (for pointing to schema/apps) and '/apps' (for apps/central/graphql mainly)
  • can tell the backend what the proxy path is by passing 'X-Forwarded-Prefix' header when proxying
  • on preview helm-chart we need proxy-prefix to be passed otherwise backend doesn't know about the prefix. Note to ops: set in the config map of the ingress, ok?
  • need to fix /apps/ui for the new UI as that still has path hardcoded in the config
  • need to test if oidc still works

@mswertz mswertz marked this pull request as draft July 15, 2025 22:10
@mswertz mswertz changed the title feat(catalogue): serve cms on path /cms feat(catalogue): enable access to platform via path /cms Jul 15, 2025
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
68.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mswertz mswertz marked this pull request as ready for review July 17, 2025 06:31
Copy link
Contributor

@connoratrug connoratrug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code / idea looks fine, although i do not like the impact of having to use the ../ back everywhere.

for the pr to be merged;

  • fix preview setup
  • update docs to describe the changes and setup needed
  • add tests changes in before handler and non standard header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants