Merge pull request #25 from molindo/add-more-rules

Add rules as mentioned in issues
molindo · Aug 2, 2019 · c352bbd · c352bbd
2 parents 550be0d + 4955320
commit c352bbd
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 9 deletions.
diff --git a/index.js b/index.js
@@ -46,11 +46,8 @@ module.exports = {
         'newlines-between': 'never'
       }
     ],
+    'no-console': [ERROR, {allow: ['warn', 'error']}],
     'no-lonely-if': ERROR,
-    'no-throw-literal': ERROR,
-    'no-var': ERROR,
-    'no-unneeded-ternary': ERROR,
-    'no-unused-expressions': ERROR,
     'no-restricted-syntax': [
       ERROR,
       {
@@ -65,6 +62,11 @@ module.exports = {
       }
     ],
     'no-shadow': ERROR,
+    'no-throw-literal': ERROR,
+    'no-unneeded-ternary': ERROR,
+    'no-unused-expressions': ERROR,
+    'no-use-before-define': [ERROR, {functions: false}],
+    'no-var': ERROR,
     'object-shorthand': ERROR,
     'prefer-arrow-callback': ERROR,
     'prefer-const': ERROR,

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-molindo",
-  "version": "3.0.0",
+  "version": "4.0.0",
   "description": "Molindo ESLint config that implements our styleguide and helps to catch errors.",
   "main": "index.js",
   "repository": "https://github.com/molindo/eslint-config-molindo",
@@ -30,12 +30,13 @@
   },
   "peerDependencies": {
     "babel-eslint": "^10.0.0",
-    "eslint": "^5.12.0",
+    "eslint": "^5.12.0 || ^6.0.0",
     "eslint-plugin-css-modules": "^2.11.0",
     "eslint-plugin-import": "^2.14.0",
     "eslint-plugin-jsx-a11y": "^6.1.2",
     "eslint-plugin-prettier": "^3.0.1",
     "eslint-plugin-react": "^7.12.3",
+    "eslint-plugin-react-hooks": "^1.6.1",
     "prettier": "^1.15.3"
   }
 }
diff --git a/react.js b/react.js
@@ -8,7 +8,11 @@ module.exports = Object.assign({}, base, {
   plugins: base.plugins.concat('css-modules', 'jsx-a11y', 'react'),
 
   settings: Object.assign({}, base.settings, {
-    'import/resolver': 'webpack'
+    'import/resolver': {
+      node: {
+        paths: ['node_modules', 'src']
+      }
+    }
   }),
 
   extends: (base.extends || []).concat(
@@ -39,6 +43,7 @@ module.exports = Object.assign({}, base, {
       }
     ],
     'react/jsx-no-bind': [ERROR, {allowArrowFunctions: true}],
+    'react/jsx-no-target-blank': ERROR,
     'react/jsx-sort-props': [
       ERROR,
       {
@@ -48,9 +53,10 @@ module.exports = Object.assign({}, base, {
     ],
     'react/no-access-state-in-setstate': ERROR,
     'react/no-direct-mutation-state': ERROR,
+    'react/no-this-in-sfc': ERROR,
+    'react/no-typos': ERROR,
     'react/no-unused-prop-types': ERROR,
     'react/no-unused-state': ERROR,
-    'react/no-typos': ERROR,
     'react/sort-comp': [
       ERROR,
       {
@@ -66,7 +72,8 @@ module.exports = Object.assign({}, base, {
           'render'
         ]
       }
-    ]
+    ],
+    'react/sort-prop-types': ERROR
   }),
 
   overrides: (base.overrides || []).concat({