-
Notifications
You must be signed in to change notification settings - Fork 79
chore: update Node.js versions in CI workflows #1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Removes support for Node.js versions 16.x to 19.x in both PR and release workflows. Adds support for Node.js 24.x to ensure alignment with the latest runtime environments. Updates NODE_VERSIONS constant to match supported versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the CI workflows and application configuration to remove outdated Node.js versions (16.x, 18.x, 19.x) and add support for Node.js 24.x.
- Updated the NODE_VERSIONS constant in docs/src/App.tsx
- Adjusted Node.js versions in both .github/workflows/release.yml and .github/workflows/pr.yml to add 24.x and remove older versions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
docs/src/App.tsx | Updated NODE_VERSIONS constant to include 24 and remove outdated versions |
.github/workflows/release.yml | Updated node-version list to support Node.js 24.x |
.github/workflows/pr.yml | Updated node-version list to support Node.js 24.x |
Investigating why it fails on 24 |
Seems to work now 😖 |
@@ -4,7 +4,7 @@ import * as vegaLite from 'vega-lite'; | |||
|
|||
// which results are attempted to load | |||
// the first is selected automatically | |||
const NODE_VERSIONS = [23, 22, 21, 20, 19, 18, 16]; | |||
const NODE_VERSIONS = [24, 23, 22, 21, 20, 19, 18, 16]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as with bun, non-benchmarked node versions (16, 18, 19) should not be shown in the app.
Weird, looking a the failures stack trace, it stems from @mondrian-framework which includes a json web token runtype that loads the jsonwebtoken library ... ⏳ ... found it: auth0/node-jwa#52 😆 so it was indeed broken in node 24 and someone fixed it already. That keeps me wondering about why aren't these transitive dependencies pinned / locked to their exact version similar to how it's done in package.json 🤔 |
Description
Removes support for Node.js versions 16.x to 19.x in both PR and release workflows. Adds support for Node.js 24.x to ensure alignment with the latest runtime environments. Updates NODE_VERSIONS constant to match supported versions.
Testing
CI
Checklist