Codable encoder key strategy update #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtweedy
commented
Dec 19, 2018
Contributor
Author
craigtweedy
left a comment
craigtweedy
left a comment
There was a problem hiding this comment.
Few things I noticed in the previous commit
craigtweedy
commented
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Type
Refactor
A code change that neither fixes a
bug nor adds a feature
Description
Swift 4.1 brought key encoding strategies, negating the need to manually specify which keys in the JSON match to properties in the object. We can now use an automatic snake_case to camelCase decoder rather than specify it manually.