Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #3

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Update dependencies #3

wants to merge 3 commits into from

Conversation

stdex
Copy link

@stdex stdex commented May 7, 2021

No description provided.

@stdex stdex marked this pull request as draft May 7, 2021 22:25
@stdex stdex marked this pull request as ready for review May 7, 2021 22:33
@kminek
Copy link
Member

kminek commented May 8, 2021

hi @stdex ! wow this is huge PR - thanks! i will try to review it in next couple of days. probably will need to change major version because a lot of dependencies got updated :)

kminek
kminek reviewed May 8, 2021
View reviewed changes
composer.json
"illuminate/database": "5.1.*",
"illuminate/cache": "5.1.*",
"illuminate/filesystem": "5.1.*",
"smarty/smarty": "3.1.*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see you're not a fan of Smarty :)

@stdex stdex marked this pull request as draft May 10, 2021 19:45
@stdex
Copy link
Author

stdex commented May 10, 2021

hi @stdex ! wow this is huge PR - thanks! i will try to review it in next couple of days. probably will need to change major version because a lot of dependencies got updated :)

It's not ready yet. Tests are not passed.
Apparently there is an incompatibility between pimple and illuminate/container. It's not transparent change.

@kminek
Copy link
Member

kminek commented May 10, 2021

hi @stdex ! wow this is huge PR - thanks! i will try to review it in next couple of days. probably will need to change major version because a lot of dependencies got updated :)

It's not ready yet. Tests are not passed.
Apparently there is an incompatibility between pimple and illuminate/container. It's not transparent change.

yes, Slim 3.* used Pimple by default as DI container. Slim 4.* does not ship with default container AFAIK. it expects external container implementing PSR container interface. So we can include Pimple in composer.json and use PSR flavour: https://github.com/silexphp/Pimple#psr-11-compatibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kminek kminek kminek left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stdex @kminek