Fixed folio duplexrotate - but at what cost...

[momijizukamori]

No description provided.

[github-actions]

PR Preview Action v1.4.7
🚀 Deployed preview to https://momijizukamori.github.io/bookbinder-js/pr-preview/pr-111/
on branch gh-pages at 2024-03-13 00:33 UTC

[acestronautical]

Code looks reasonable, not sure I love the naming. ‘Alt’ is pretty generic and I think we use it elsewhere to maybe mean something else?

[momijizukamori]

Code looks reasonable, not sure I love the naming. ‘Alt’ is pretty generic and I think we use it elsewhere to maybe mean something else?

I think the one spot we use it was left over from my initial pass at trying to get folio working (like two years ago), but I will go back through.

[sithel]

am too fried to review this tonight, sorry. Will pass on though that nonbinary_octopus (who had asked about it this afternoon) tested it and 👍 (which is mostly what I care about) -- will ask for version number bump for this this once url changes land

[acestronautical]

Do we need to remove the 'NOTE: Not currently working for folios, sorry! Use the old version for now.' text from html?

[Aspharon]

So, uh, any news on this? It's been a while.

[momijizukamori]

Mostly it needs testing, which is unfortunately a thing I have not had the time/bandwidth to do and which nobody else has stepped in to do. The preview deploy in the second comment should still work though, if you want to give it a go and report back.