refactor(usePlaygroundState): use centralized hook to manage core state and state updates of addon #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h @storybook/theming
…ency this should solve the performance issues, it was caused by the fact that every time the rendered code changed, it automatically updated the code injected to the Editor. Now the temp code from editor is independent from the rendered code
…e from addon's parameters
note: this is a workaround as playground story is not declaring itself as prepared if it is the first story to be rendered
…aming convention must start with "use" and storybook convention is start with "with"
…te and state updates of addon
Contributor
Author
|
There's some issue with the |
Base automatically changed from
feat/yossi/Playground---allow-introCode-to-show-welcome-code-for-users-5810353594
to
fix/yossi/Playground---Solve-performance-issues-5767510433
January 14, 2024 10:17
Base automatically changed from
fix/yossi/Playground---Solve-performance-issues-5767510433
to
master
January 14, 2024 10:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/5818050323
This is a refactor PR to make the code cleaner and manage the addon state on a centralized place instead of being spread across other hooks/managed straight from storybook's
useAddonState