feat(Modal): implement size prop and responsiveness #2419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YossiSaadi
force-pushed
the
feat/yossi/modal-responsiveness-different-sizes-should-render-7360732026
branch
from
cc54536 to
7ab0d78
Compare
YossiSaadi
force-pushed
the
feat/yossi/basic-modal-component-to-act-as-modals-canvas-7360583166
branch
from
ab039e7 to
29b4ff9
Compare
Base automatically changed from
feat/yossi/basic-modal-component-to-act-as-modals-canvas-7360583166
to
feat/yossi/new-modal-building-blocks-7359960492
September 24, 2024 11:52
YossiSaadi
force-pushed
the
feat/yossi/modal-responsiveness-different-sizes-should-render-7360732026
branch
from
f54c29f to
f15bd80
Compare
YossiSaadi
merged commit 3908e98
into
feat/yossi/new-modal-building-blocks-7359960492
8 checks passed
YossiSaadi
deleted the
feat/yossi/modal-responsiveness-different-sizes-should-render-7360732026
branch
YossiSaadi
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsiveness
https://monday.monday.com/boards/3532715121/pulses/7360732026