feat(Modal): disable scroll outside of modal when it is open #2433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
approved these changes
Sep 24, 2024
YossiSaadi
force-pushed
the
feat/yossi/modal-handle-show-and-on-close-logic-7368472599
branch
2 times, most recently
from
6d65e90 to
415e639
Compare
YossiSaadi
force-pushed
the
feat/yossi/modal-a11y-lock-scroll-of-parts-other-than-modal-when-opened-7391259531
branch
from
4de4dfc to
6306ce0
Compare
Base automatically changed from
feat/yossi/modal-handle-show-and-on-close-logic-7368472599
to
feat/yossi/new-modal-building-blocks-7359960492
September 25, 2024 07:38
YossiSaadi
force-pushed
the
feat/yossi/modal-a11y-lock-scroll-of-parts-other-than-modal-when-opened-7391259531
branch
from
6306ce0 to
26df930
Compare
YossiSaadi
merged commit c95b799
into
feat/yossi/new-modal-building-blocks-7359960492
4 checks passed
YossiSaadi
deleted the
feat/yossi/modal-a11y-lock-scroll-of-parts-other-than-modal-when-opened-7391259531
branch
YossiSaadi
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable scroll
Decided to go with
react-remove-scrollwhich seem to be the most popular and bulletproof solution, the bundle cost is also very very lighthttps://monday.monday.com/boards/3532715121/pulses/7391259531