Skip to content

Conversation

@rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar commented Sep 29, 2025

User description

https://monday.monday.com/boards/3532714909/views/80492480/pulses/10052450745


PR Type

Enhancement


Description

  • Move Dropdown component from alpha to stable release

  • Update import paths and file structure organization

  • Mark old Dropdown as deprecated with migration guidance

  • Remove alpha warnings from new Dropdown documentation


Diagram Walkthrough

flowchart LR
  A["Alpha Dropdown"] --> B["Stable Dropdown"]
  C["Old Dropdown"] --> D["Legacy Dropdown (Deprecated)"]
  B --> E["Updated Import Paths"]
  D --> F["Migration Guide"]
Loading

File Walkthrough

Relevant files
Configuration changes
16 files
next.ts
Remove DropdownNew export from next module                             
+0/-1     
index.ts
Add Dropdown export to next index                                               
+1/-0     
Dropdown.types.ts
Update import paths for component dependencies                     
+4/-4     
DropdownContext.ts
Fix import paths for BaseList components                                 
+2/-2     
DropdownContext.types.ts
Update import paths for type definitions                                 
+3/-3     
useDropdownCombobox.ts
Fix BaseListItemData import path                                                 
+1/-1     
useDropdownFiltering.ts
Update BaseList and BaseListItemData imports                         
+2/-2     
useDropdownMultiCombobox.ts
Fix BaseListItemData import path                                                 
+1/-1     
useDropdownMultiSelect.ts
Update BaseListItemData import path                                           
+1/-1     
useDropdownSelect.ts
Fix BaseListItemData import path                                                 
+1/-1     
dropdownUtils.ts
Update BaseList component import paths                                     
+2/-2     
Dropdown.tsx
Fix import paths for hooks and types                                         
+2/-2     
Dropdown.stories.tsx
Update story title and import paths                                           
+6/-6     
Dropdown.test.tsx
Fix import paths in test file                                                       
+2/-2     
DropdownBase.tsx
Update component import paths                                                       
+6/-6     
DropdownPopup.tsx
Fix Dialog component import path                                                 
+1/-1     
Documentation
3 files
Dropdown.mdx
Mark old Dropdown as deprecated                                                   
+5/-1     
Dropdown.stories.jsx
Update story title to indicate deprecation                             
+1/-1     
Dropdown.mdx
Remove alpha warning from documentation                                   
+0/-4     
Additional files
19 files
DropdownBase.module.scss [link]   
DropdownWrapperUI.tsx +1/-1     
Menu.module.scss [link]   
Menu.tsx +3/-3     
MultiSelectedValues.module.scss [link]   
MultiSelectedValues.tsx +6/-6     
DropdownChip.tsx +2/-2     
DropdownInput.tsx +3/-3     
MultiSelectTrigger.tsx +3/-3     
SingleSelectTrigger.tsx +3/-3     
Trigger.module.scss [link]   
TriggerActions.tsx +4/-4     
index.ts [link]   
DropdownComboboxController.tsx +1/-1     
DropdownMultiComboboxController.tsx +1/-1     
DropdownMultiSelectController.tsx +1/-1     
DropdownSelectController.tsx +1/-1     
dropdown-modifiers.ts [link]   
dropdown-migration-guide.mdx +1/-6     

@rivka-ungar rivka-ungar requested a review from a team as a code owner September 29, 2025 10:42
@rivka-ungar rivka-ungar changed the title docs(Dropdown): mark old Dropdown as deprecated and update migration references docs(Dropdown): mark old Dropdown as deprecated and remove alpha from new Sep 29, 2025
@qodo-merge-for-open-source qodo-merge-for-open-source bot changed the title docs(Dropdown): mark old Dropdown as deprecated and remove alpha from new docs(Dropdown): mark old Dropdown as deprecated and update migration references Sep 29, 2025
@qodo-merge-for-open-source
Copy link
Contributor

qodo-merge-for-open-source bot commented Sep 29, 2025

PR Reviewer Guide 🔍

(Review updated until commit bcf17d1)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Export Surface

New export for ./Dropdown is added; confirm tree-shaking and public API consistency (named vs default exports) and that no duplicate re-exports cause circular dependencies.

export * from "./AttentionBox";
export * from "./Dropdown";
Import Path Update

Updated Dialog import path; verify no breaking style or behavior differences due to path change and that the component is correctly bundled.

import React from "react";
import Dialog from "../../../../Dialog/Dialog";
import { matchWidthModifier } from "../../utils/dropdown-modifiers";
Deprecated Docs Links

Deprecated notice links to new docs; validate that the alternativeLink path resolves and Storybook titles remain unique and searchable.

# Dropdown - Deprecated

<br />

<DeprecatedWarning alternativeName="Dropdown" alternativeLink="/?path=/docs/components-dropdown-new--docs" />

@rivka-ungar rivka-ungar changed the title docs(Dropdown): mark old Dropdown as deprecated and update migration references refactor(Dropdown): move to next Sep 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2025

📦 Bundle Size Analysis

✅ No bundle size changes detected.

Unchanged Components
Component Base PR Diff
Accordion 6.33KB 6.33KB 0B ➖
AccordionItem 67.8KB 67.8KB 0B ➖
AlertBanner 72.54KB 72.54KB 0B ➖
AlertBannerButton 19KB 19KB 0B ➖
AlertBannerLink 15.38KB 15.38KB 0B ➖
AlertBannerText 65.15KB 65.15KB 0B ➖
AttentionBox 74.01KB 74.01KB 0B ➖
AttentionBoxLink 15.26KB 15.26KB 0B ➖
Avatar 67.97KB 67.97KB 0B ➖
AvatarGroup 95.34KB 95.34KB 0B ➖
Badge 43.56KB 43.56KB 0B ➖
Box 9.29KB 9.29KB 0B ➖
BreadcrumbItem 65.83KB 65.83KB 0B ➖
BreadcrumbMenu 69.95KB 69.95KB 0B ➖
BreadcrumbMenuItem 78.67KB 78.67KB 0B ➖
BreadcrumbsBar 5.78KB 5.78KB 0B ➖
Button 18.72KB 18.72KB 0B ➖
ButtonGroup 69.96KB 69.96KB 0B ➖
Checkbox 68.14KB 68.14KB 0B ➖
Chips 76.67KB 76.67KB 0B ➖
Clickable 6.27KB 6.27KB 0B ➖
ColorPicker 75.86KB 75.86KB 0B ➖
ColorPickerContent 75.12KB 75.12KB 0B ➖
Combobox 85.57KB 85.57KB 0B ➖
Counter 42.36KB 42.36KB 0B ➖
DatePicker 134.12KB 134.12KB 0B ➖
Dialog 54.03KB 54.03KB 0B ➖
DialogContentContainer 6.31KB 6.31KB 0B ➖
Divider 5.54KB 5.54KB 0B ➖
Dropdown 125.24KB 125.24KB 0B ➖
menu 59.95KB 59.95KB 0B ➖
option 92.72KB 92.72KB 0B ➖
singleValue 92.74KB 92.74KB 0B ➖
EditableHeading 67.75KB 67.75KB 0B ➖
EditableText 67.75KB 67.75KB 0B ➖
EmptyState 72.39KB 72.39KB 0B ➖
ExpandCollapse 67.52KB 67.52KB 0B ➖
Flex 7.49KB 7.49KB 0B ➖
FormattedNumber 5.87KB 5.87KB 0B ➖
GridKeyboardNavigationContext 4.65KB 4.65KB 0B ➖
Heading 66.51KB 66.51KB 0B ➖
HiddenText 5.41KB 5.41KB 0B ➖
CustomSvgIcon 11.86KB 11.86KB 0B ➖
Icon 13.82KB 13.82KB 0B ➖
IconButton 69.55KB 69.55KB 0B ➖
Info 73.86KB 73.86KB 0B ➖
Label 69.95KB 69.95KB 0B ➖
LayerProvider 2.95KB 2.95KB 0B ➖
LegacyModal 76.37KB 76.37KB 0B ➖
LegacyModalContent 66.56KB 66.56KB 0B ➖
LegacyModalFooter 3.45KB 3.45KB 0B ➖
LegacyModalFooterButtons 20.48KB 20.48KB 0B ➖
LegacyModalHeader 72.52KB 72.52KB 0B ➖
Link 15.02KB 15.02KB 0B ➖
List 74.41KB 74.41KB 0B ➖
ListItem 67.03KB 67.03KB 0B ➖
ListItemAvatar 68.1KB 68.1KB 0B ➖
ListItemIcon 14.12KB 14.12KB 0B ➖
ListTitle 66.52KB 66.52KB 0B ➖
Loader 5.83KB 5.83KB 0B ➖
Menu 8.63KB 8.63KB 0B ➖
MenuDivider 5.64KB 5.64KB 0B ➖
MenuGridItem 7.22KB 7.22KB 0B ➖
MenuItem 78.7KB 78.7KB 0B ➖
MenuItemButton 71.76KB 71.76KB 0B ➖
MenuTitle 66.83KB 66.83KB 0B ➖
MenuButton 67.59KB 67.59KB 0B ➖
MultiStepIndicator 53.07KB 53.07KB 0B ➖
NumberField 74.59KB 74.59KB 0B ➖
LinearProgressBar 7.45KB 7.45KB 0B ➖
RadioButton 67.34KB 67.34KB 0B ➖
Search 72.15KB 72.15KB 0B ➖
Skeleton 6.19KB 6.19KB 0B ➖
Slider 75.58KB 75.58KB 0B ➖
SplitButton 68.42KB 68.42KB 0B ➖
SplitButtonMenu 8.83KB 8.83KB 0B ➖
Steps 73.08KB 73.08KB 0B ➖
Table 7.3KB 7.3KB 0B ➖
TableBody 68.29KB 68.29KB 0B ➖
TableCell 66.59KB 66.59KB 0B ➖
TableContainer 5.36KB 5.36KB 0B ➖
TableHeader 5.71KB 5.71KB 0B ➖
TableHeaderCell 73.77KB 73.77KB 0B ➖
TableRow 5.6KB 5.6KB 0B ➖
TableRowMenu 70.3KB 70.3KB 0B ➖
TableVirtualizedBody 72.94KB 72.94KB 0B ➖
Tab 65.23KB 65.23KB 0B ➖
TabList 8.92KB 8.92KB 0B ➖
TabPanel 5.35KB 5.35KB 0B ➖
TabPanels 5.91KB 5.91KB 0B ➖
TabsContext 5.54KB 5.54KB 0B ➖
Text 66.41KB 66.41KB 0B ➖
TextArea 67.66KB 67.66KB 0B ➖
TextField 70.96KB 70.96KB 0B ➖
TextWithHighlight 65.58KB 65.58KB 0B ➖
ThemeProvider 4.69KB 4.69KB 0B ➖
Tipseen 72.83KB 72.83KB 0B ➖
TipseenContent 73.36KB 73.36KB 0B ➖
TipseenImage 73.15KB 73.15KB 0B ➖
TipseenMedia 73.04KB 73.04KB 0B ➖
TipseenWizard 75.58KB 75.58KB 0B ➖
Toast 75.64KB 75.64KB 0B ➖
ToastButton 18.89KB 18.89KB 0B ➖
ToastLink 15.25KB 15.25KB 0B ➖
Toggle 68.03KB 68.03KB 0B ➖
Tooltip 64.4KB 64.4KB 0B ➖
TransitionView 37.73KB 37.73KB 0B ➖
VirtualizedGrid 12.61KB 12.61KB 0B ➖
VirtualizedList 12.36KB 12.36KB 0B ➖

📊 Summary:

  • Total Base Size: 5.12MB
  • Total PR Size: 5.12MB
  • Total Difference: +0B

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@rivka-ungar rivka-ungar merged commit c4f7010 into master Sep 29, 2025
17 checks passed
@rivka-ungar rivka-ungar deleted the dropdown-remove-alpha-banner-and-mark-old-as-deprecated-10052450745 branch September 29, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants