Skip to content

fix(ButtonGroup): apply fullWidth to root element #3134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+4 −5
Open

fix(ButtonGroup): apply fullWidth to root element #3134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ad56f52
fix(ButtonGroup): apply fullWidth to root element for proper width be…
emmanuel-ferdman Oct 1, 2025
da9d757
fix(ButtonGroup): apply `fullWidth` to root element
emmanuel-ferdman Oct 9, 2025
157d90f
Merge branch 'master' into master
emmanuel-ferdman Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/core/src/components/ButtonGroup/__stories__/ButtonGroup.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React from "react";
import ButtonGroup from "../ButtonGroup";
import { createStoryMetaSettingsDecorator } from "../../../storybook";
import { createComponentTemplate } from "vibe-storybook-components";
import { type Meta, type StoryObj } from "@storybook/react";
import Text from "../../Text/Text";
import Flex from "../../Flex/Flex";
Expand All @@ -13,8 +12,6 @@ const metaSettings = createStoryMetaSettingsDecorator({
actionPropsArray: ["onSelect"]
});

const buttonGroupTemplate = createComponentTemplate(ButtonGroup);

export default {
title: "Components/ButtonGroup",
component: ButtonGroup,
Expand All @@ -23,8 +20,10 @@ export default {
} satisfies Meta<typeof ButtonGroup>;

export const Overview: Story = {
render: buttonGroupTemplate.bind({}),

render: args => {
const content = <ButtonGroup {...args} />;
return args.fullWidth ? <div style={{ width: "100%" }}>{content}</div> : content;
},
args: {
id: "overview-button-group",
groupAriaLabel: "Overview button group",
Expand Down