Skip to content

Conversation

@talkor
Copy link
Member

@talkor talkor commented Oct 23, 2025

PR Type

Enhancement


Description

  • Migrated Storybook stories from packages/core to a new dedicated packages/docs package, establishing a clear separation between component library and documentation

  • Consolidated all story file imports to use centralized @vibe/core, @vibe/core/next, and @vibe/core/interactionsTests package exports instead of relative paths

  • Centralized interaction test utilities by exporting resetFocus from @vibe/core/interactionsTests and consolidating test data IDs and constants into individual story files

  • Updated Storybook configuration to discover and build stories from the new docs package, including webpack path aliases for core packages

  • Created comprehensive package infrastructure for docs package including package.json, TypeScript configuration, and Vite configuration

  • Migrated test utilities and constants from @vibe/shared package, including ContentColorByName color mappings and test constants

  • Updated GitHub Actions workflow (Chromatic) to reference the new docs package location

  • Removed deprecated @vibe/storybook-config package and consolidated its utilities into the docs package

  • Updated documentation and cursor rules to reflect new stories organization and import patterns


Diagram Walkthrough

flowchart LR
  A["packages/core<br/>Components & Hooks"] -->|"exports via<br/>@vibe/core"| B["packages/docs<br/>Storybook Stories"]
  C["packages/shared<br/>Test Utilities"] -->|"exports via<br/>@vibe/shared"| B
  D["packages/core<br/>Interaction Tests"] -->|"exports via<br/>@vibe/core/interactionsTests"| B
  B -->|"Storybook Config<br/>& Build"| E["Chromatic<br/>& Documentation"]
  F["Removed:<br/>@vibe/storybook-config"] -.->|"consolidated into"| B
Loading

File Walkthrough

Relevant files
Enhancement
69 files
ThemeProvider.interactions.ts
Consolidate imports and inline utility functions for theme
interactions

packages/docs/src/pages/components/ThemeProvider/ThemeProvider.interactions.ts

  • Migrated imports from local paths to @vibe/core and
    @vibe/core/interactionsTests packages
  • Inlined utility functions (addAppThemeSuffix,
    getBodySystemThemeClassName, getComputedVarColor, hexToRgb) that were
    previously imported from separate files
  • Updated SystemTheme import to use type import from @vibe/core
  • Changed hardcoded theme string from SystemTheme.DARK to "dark"
+43/-5   
Combobox.interactions.ts
Centralize interaction test imports to core package           

packages/docs/src/pages/components/Combobox/Combobox.interactions.ts

  • Migrated imports from local test utilities to
    @vibe/core/interactionsTests package
  • Consolidated imports from multiple local files into single
    @vibe/core/interactionsTests import
  • Updated imports to use @vibe/shared for test constants and utilities
  • Removed local resetFocus import in favor of centralized version
+7/-6     
Dialog.interactions.ts
Consolidate Dialog test data and interaction imports         

packages/docs/src/pages/components/Dialog/Dialog.interactions.ts

  • Migrated imports from local paths to @vibe/core/interactionsTests
  • Moved test data IDs (CLICK_OUTSIDE_DIALOG, CONTEXT_MENU_DIALOG, etc.)
    from separate file into this file as exports
  • Removed dependency on DialogDataTestIds file
+7/-7     
ColorPicker.interactions.ts
Consolidate ColorPicker test utilities and imports             

packages/docs/src/pages/components/ColorPicker/ColorPicker.interactions.ts

  • Migrated imports from local test utilities to
    @vibe/core/interactionsTests
  • Inlined ContentColorByName color mapping that was previously imported
    from utils
  • Updated imports to use @vibe/shared for test constants
  • Removed local resetFocus import
+10/-5   
useActiveDescendantListFocus.interactions.ts
Centralize hook interaction test imports                                 

packages/docs/src/pages/hooks/useActiveDescendantListFocus/useActiveDescendantListFocus.interactions.ts

  • Migrated all interaction test imports to @vibe/core/interactionsTests
  • Updated imports to use @vibe/shared for test constants
  • Changed stylesheet import path from __stories__ directory to local
    module
+9/-6     
playground-helpers.ts
Update playground helpers to use centralized package imports

packages/docs/src/pages/playground/playground-helpers.ts

  • Updated component imports to use @vibe/core and @vibe/core/next
    packages instead of local paths
  • Removed VibeHooks import and reference from exported playground
    components
  • Simplified imports by using centralized package exports
+3/-4     
interactions-utils.ts
Export resetFocus utility function                                             

packages/core/src/tests/interactions-utils.ts

  • Added resetFocus function export that was previously defined elsewhere
  • Function clicks on focus trap element if present to reset focus state
+7/-0     
Heading.interactions.ts
Consolidate Heading test constants and interaction imports

packages/docs/src/pages/components/Heading/Heading.interactions.ts

  • Migrated imports to @vibe/core/interactionsTests
  • Moved test constants (ONE_LINE_ELLIPSIS_TEST_ID,
    OVERFLOW_TITLE_CONTAINER_ID) into this file as exports
  • Updated Tooltip import path to use relative path from current location
+5/-3     
Text.interactions.ts
Consolidate Text test constants and interaction imports   

packages/docs/src/pages/components/Text/Text.interactions.ts

  • Migrated imports to @vibe/core/interactionsTests
  • Moved test constants (ONE_LINE_ELLIPSIS_TEST_ID,
    OVERFLOW_TEXT_CONTAINER_ID) into this file as exports
  • Updated Tooltip import path to use relative path from current location
+5/-3     
Clickable.interactions.ts
Centralize Clickable interaction test imports                       

packages/docs/src/pages/components/Clickable/Clickable.interactions.ts

  • Migrated all interaction test imports to @vibe/core/interactionsTests
  • Consolidated multiple local imports into single centralized import
+8/-3     
Menu.interactions.ts
Centralize Menu interaction test imports                                 

packages/docs/src/pages/components/Menu/Menu.interactions.ts

  • Migrated all interaction test imports to @vibe/core/interactionsTests
  • Consolidated imports from multiple local files into single package
    import
+4/-4     
useGridKeyboardNavigationContext.interactions.ts
Centralize grid keyboard navigation interaction imports   

packages/docs/src/pages/components/GridKeyboardNavigationContext/useGridKeyboardNavigationContext.interactions.ts

  • Migrated interaction test imports to @vibe/core/interactionsTests
  • Consolidated imports from multiple local files into single package
    import
+1/-2     
colors-utils.ts
Convert ColorUtils to named export                                             

packages/shared/src/utils/colors-utils.ts

  • Changed ColorUtils from default export to named export
  • Removed Object.freeze() wrapper from export
+1/-3     
EditableHeading.interactions.ts
Centralize EditableHeading interaction test imports           

packages/docs/src/pages/components/EditableHeading/EditableHeading.interactions.ts

  • Migrated interaction test imports to @vibe/core/interactionsTests
  • Updated test constant imports to use @vibe/shared
+4/-5     
EditableText.interactions.ts
Centralize EditableText interaction test imports                 

packages/docs/src/pages/components/EditableText/EditableText.interactions.ts

  • Migrated interaction test imports to @vibe/core/interactionsTests
  • Updated test constant imports to use @vibe/shared
+4/-5     
Slider.interactions.ts
Centralize Slider interaction test imports                             

packages/docs/src/pages/components/Slider/Slider.interactions.ts

  • Migrated interaction test imports to @vibe/core/interactionsTests
  • Consolidated imports from multiple local files into single package
    import
+2/-2     
Accordion.interactions.ts
Centralize Accordion interaction test imports                       

packages/docs/src/pages/components/Accordion/Accordion.interactions.ts

  • Migrated interaction test imports to @vibe/core/interactionsTests
  • Consolidated imports from multiple local files into single package
    import
+1/-2     
Tooltip.interactions.ts
Update Tooltip test constant imports                                         

packages/docs/src/pages/components/Tooltip/Tooltip.interactions.ts

  • Updated test constant imports to use @vibe/shared instead of local
    path
+1/-1     
RadioButton.interactions.ts
Centralize RadioButton interaction test imports                   

packages/docs/src/pages/components/RadioButton/RadioButton.interactions.ts

  • Migrated interaction test imports to @vibe/core/interactionsTests
+1/-1     
Dropdown.interactions.ts
Centralize legacy Dropdown interaction test imports           

packages/docs/src/pages/components/Dropdown/legacy/Dropdown.interactions.ts

  • Migrated interaction test imports to @vibe/core/interactionsTests
+1/-1     
useActiveDescendantListFocus.module.scss
Update SCSS import to use monday-ui-style package               

packages/docs/src/pages/hooks/useActiveDescendantListFocus/useActiveDescendantListFocus.module.scss

  • Changed import from local styles to monday-ui-style package
+1/-1     
Loader.stories.tsx
Add Loader component stories                                                         

packages/docs/src/pages/components/Loader/Loader.stories.tsx

  • Created new Loader component stories file with multiple story variants
  • Includes Overview, SizeVariants, ColorVariants, CustomColors,
    VisualVariants, LoaderInTextField, and LoaderInButton stories
  • Imports components from @vibe/core package
+178/-0 
Chips.stories.tsx
Update Chips stories to use centralized imports                   

packages/docs/src/pages/components/Chips/Chips.stories.tsx

  • Updated component imports to use @vibe/core package
  • Changed asset imports to use Avatar assets directory
  • Replaced NOOP utility with inline arrow function
  • Updated person image references in stories
+9/-22   
ModalSideBySideLayout.stories.tsx
Update Modal SideBySide layout stories imports                     

packages/docs/src/pages/components/Modal/ModalSideBySideLayout.stories.tsx

  • Updated imports to use @vibe/core and @vibe/core/next packages
  • Simplified import paths for Modal-related components
  • Updated helper function imports to use local paths
  • Changed FieldLabel to Label component
+26/-22 
Text.stories.tsx
Update Text stories to use centralized imports                     

packages/docs/src/pages/components/Text/Text.stories.tsx

  • Updated component imports to use @vibe/core package
  • Moved test constants and interaction suite imports to local file
  • Changed HeadingType.H3 to string literal "h3"
  • Updated utility function imports
+7/-13   
component-description-map.tsx
Update component description map imports                                 

packages/docs/src/layout/related-components/component-description-map.tsx

  • Removed HiddenTextDescription import
  • Updated Modal layout related component imports to use local
    descriptions directory
  • Reorganized import structure
+3/-7     
Icon.stories.tsx
Update Icon stories to use centralized imports                     

packages/docs/src/pages/components/Icon/Icon.stories.tsx

  • Updated component imports to use @vibe/core package
  • Updated utility function import path
  • Removed TODO comments and enabled Search component usage
  • Replaced inline div with Flex component
+6/-16   
Slider.stories.tsx
Update Slider stories to use centralized imports                 

packages/docs/src/pages/components/Slider/Slider.stories.tsx

  • Updated component imports to use @vibe/core package
  • Updated utility function import path
  • Added type annotations to callback functions
+6/-7     
Dialog.stories.tsx
Update Dialog stories to use centralized imports                 

packages/docs/src/pages/components/Dialog/Dialog.stories.tsx

  • Updated component imports to use @vibe/core package
  • Moved test data IDs and interaction suite to local file
  • Defined dialogTriggerEvents array inline instead of importing from
    constants
  • Updated hook imports to use @vibe/core
+31/-10 
Label.stories.tsx
Update Label stories to use centralized imports                   

packages/docs/src/pages/components/Label/Label.stories.tsx

  • Updated component imports to use @vibe/core package
  • Replaced NOOP utility with inline arrow function
  • Removed liveEdit scope parameter for NOOP
+5/-18   
Accordion.stories.tsx
Migrate to centralized core package imports                           

packages/docs/src/pages/components/Accordion/Accordion.stories.tsx

  • Replaced relative imports with centralized @vibe/core package imports
  • Updated interaction test imports to use local path instead of
    __tests__ directory
  • Consolidated multiple component imports into single statement
+2/-5     
menu-grid-item-description.tsx
Update imports to use core package                                             

packages/docs/src/layout/related-components/descriptions/menu-grid-item-description.tsx

  • Changed DummyNavigableGrid import path from __stories__ to local pages
    directory
  • Migrated MenuGridItem import to use @vibe/core package
+2/-2     
ExpandCollapse.stories.tsx
Centralize imports to core package                                             

packages/docs/src/pages/components/ExpandCollapse/ExpandCollapse.stories.tsx

  • Consolidated component imports from relative paths to @vibe/core
    package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-4     
BreadcrumbsBar.mdx
Consolidate component imports to core package                       

packages/docs/src/pages/components/BreadcrumbsBar/BreadcrumbsBar.mdx

  • Migrated all component imports to use @vibe/core package
  • Consolidated five separate imports into single statement
+1/-5     
Checkbox.mdx
Update imports to centralized core package                             

packages/docs/src/pages/components/Checkbox/Checkbox.mdx

  • Migrated component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-3     
content-colors.tsx
Migrate to centralized package imports                                     

packages/docs/src/pages/foundations/colors/content-colors/content-colors.tsx

  • Migrated ContentColorByName import to @vibe/shared package
  • Updated Text component import to use @vibe/core package
+2/-2     
Spacing.mdx
Update component imports to core package                                 

packages/docs/src/pages/foundations/spacing/Spacing.mdx

  • Updated Text import to use @vibe/core package
  • Simplified SpacingStories import path
+2/-2     
AttentionBox.mdx
Migrate to centralized core package imports                           

packages/docs/src/pages/components/AttentionBox/AttentionBox.mdx

  • Migrated AttentionBox import to @vibe/core/next package
  • Consolidated remaining component imports to @vibe/core package
+2/-5     
Table.mdx
Consolidate table component imports                                           

packages/docs/src/pages/components/Table/Table.mdx

  • Consolidated seven separate component imports into single @vibe/core
    statement
  • Removed individual relative import paths
+1/-7     
Tabs.mdx
Consolidate tab component imports                                               

packages/docs/src/pages/components/Tabs/Tabs.mdx

  • Migrated tab components to @vibe/core package
  • Consolidated imports into single statement
+1/-3     
VirtualizedGrid.stories.tsx
Migrate to centralized core package                                           

packages/docs/src/pages/components/VirtualizedGrid/VirtualizedGrid.stories.tsx

  • Migrated VirtualizedGrid and Button imports to @vibe/core package
  • Updated Flex import to use centralized package
+2/-3     
MenuItem.stories.tsx
Migrate menu imports to core package                                         

packages/docs/src/pages/components/Menu/MenuItem.stories.tsx

  • Consolidated menu component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-3     
Badge.mdx
Consolidate imports and update asset paths                             

packages/docs/src/pages/components/Badge/Badge.mdx

  • Consolidated component imports to @vibe/core package
  • Updated asset import path to use Avatar assets directory
  • Removed unused Indicator component import
+2/-6     
NumberField.stories.tsx
Migrate to centralized core package                                           

packages/docs/src/pages/components/NumberField/NumberField.stories.tsx

  • Migrated component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-3     
dialog-description.tsx
Consolidate dialog component imports                                         

packages/docs/src/layout/related-components/descriptions/dialog-description/dialog-description.tsx

  • Consolidated all component imports to @vibe/core package
  • Removed individual relative import paths
+1/-4     
Toggle.stories.tsx
Migrate to centralized core package                                           

packages/docs/src/pages/components/Toggle/Toggle.stories.tsx

  • Migrated component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-4     
ButtonGroup.stories.tsx
Migrate to centralized core package                                           

packages/docs/src/pages/components/ButtonGroup/ButtonGroup.stories.tsx

  • Consolidated component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-4     
Tipseen.mdx
Consolidate tipseen imports to core package                           

packages/docs/src/pages/components/Tipseen/Tipseen.mdx

  • Consolidated tipseen component imports to @vibe/core package
+1/-3     
split-button-description.tsx
Consolidate split button imports                                                 

packages/docs/src/layout/related-components/descriptions/split-button-description.tsx

  • Consolidated split button component imports to @vibe/core package
+1/-3     
SplitButton.mdx
Migrate split button imports to core                                         

packages/docs/src/pages/components/SplitButton/SplitButton.mdx

  • Migrated SplitButton and Button imports to @vibe/core package
+1/-2     
menu-description.tsx
Consolidate menu component imports                                             

packages/docs/src/layout/related-components/descriptions/menu-description.tsx

  • Consolidated menu component imports to @vibe/core package
+1/-3     
useGridKeyboardNavigation.stories.tsx
Migrate hook to centralized core package                                 

packages/docs/src/pages/hooks/useGridKeyboardNavigation/useGridKeyboardNavigation.stories.tsx

  • Migrated hook and Button imports to @vibe/core package
+1/-2     
Info.stories.tsx
Migrate to centralized core package                                           

packages/docs/src/pages/components/Info/Info.stories.tsx

  • Consolidated component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-5     
Link.stories.tsx
Migrate link imports to core package                                         

packages/docs/src/pages/components/Link/Link.stories.tsx

  • Migrated Link component import to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-2     
BreadcrumbItem.stories.tsx
Migrate breadcrumb imports to core                                             

packages/docs/src/pages/components/BreadcrumbsBar/BreadcrumbItem.stories.tsx

  • Consolidated breadcrumb component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-3     
tipseen-description.tsx
Consolidate tipseen imports                                                           

packages/docs/src/layout/related-components/descriptions/tipseen-description.tsx

  • Consolidated tipseen component imports to @vibe/core package
+1/-2     
IconButton.mdx
Consolidate icon button imports                                                   

packages/docs/src/pages/components/IconButton/IconButton.mdx

  • Consolidated component imports to @vibe/core package
+1/-2     
MenuItemButton.stories.tsx
Migrate menu imports to core package                                         

packages/docs/src/pages/components/Menu/MenuItemButton.stories.tsx

  • Consolidated menu component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-3     
DialogContentContainer.stories.tsx
Migrate to centralized core package                                           

packages/docs/src/pages/components/Dialog/DialogContentContainer.stories.tsx

  • Consolidated component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-3     
LinearProgressBar.stories.helpers.tsx
Consolidate progress bar imports                                                 

packages/docs/src/pages/components/ProgressBars/LinearProgressBar.stories.helpers.tsx

  • Consolidated component imports to @vibe/core package
+1/-4     
MultiStepIndicator.stories.tsx
Migrate multi-step indicator to core                                         

packages/docs/src/pages/components/MultiStepIndicator/MultiStepIndicator.stories.tsx

  • Migrated MultiStepIndicator and Step type to @vibe/core package
  • Removed local type import
+1/-2     
typography.mdx
Consolidate typography imports                                                     

packages/docs/src/pages/foundations/typography/typography.mdx

  • Consolidated typography component imports to @vibe/core package
+1/-2     
breadcrumbs-description.tsx
Consolidate breadcrumb imports                                                     

packages/docs/src/layout/related-components/descriptions/breadcrumbs-description.tsx

  • Consolidated breadcrumb component imports to @vibe/core package
+1/-2     
expand-collapse-description.tsx
Consolidate expand-collapse imports                                           

packages/docs/src/layout/related-components/descriptions/expand-collapse-description/expand-collapse-description.tsx

  • Consolidated expand-collapse component imports to @vibe/core package
  • Updated Icon import source
+1/-3     
useAfterFirstRender.stories.tsx
Migrate hook to centralized core package                                 

packages/docs/src/pages/hooks/useAfterFirstRender/useAfterFirstRender.stories.tsx

  • Migrated hook and component imports to @vibe/core package
+1/-4     
menu-button-description.tsx
Consolidate menu button imports                                                   

packages/docs/src/layout/related-components/descriptions/menu-button-description.tsx

  • Consolidated menu button component imports to @vibe/core package
+1/-3     
Checkbox.stories.tsx
Migrate to centralized core package                                           

packages/docs/src/pages/components/Checkbox/Checkbox.stories.tsx

  • Consolidated component imports to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-3     
TextArea.stories.tsx
Migrate to centralized core package                                           

packages/docs/src/pages/components/TextArea/TextArea.stories.tsx

  • Migrated TextArea component import to @vibe/core package
  • Updated utility import path to
    ../../../utils/createStoryMetaSettingsDecorator
+2/-2     
VirtualizedList.stories.tsx
Consolidate virtualized list imports                                         

packages/docs/src/pages/components/VirtualizedList/VirtualizedList.stories.tsx

  • Consolidated component imports to @vibe/core package
  • Removed relative import paths
+1/-3     
Configuration changes
7 files
main.ts
Configure Storybook to include core package stories and aliases

packages/docs/.storybook/main.ts

  • Added story paths for @vibe/core package (.mdx and .stories files)
  • Added path aliases for @vibe/core/interactionsTests, @vibe/core/next,
    and @vibe/core in webpack configuration
  • Reorganized story discovery to include core package stories alongside
    docs package stories
+5/-1     
vite.config.ts
Add Vite configuration for docs package                                   

packages/docs/vite.config.ts

  • Created new Vite configuration file for docs package
  • Configured React plugin for Vite
+6/-0     
package.json
Create package.json for docs package                                         

packages/docs/package.json

  • Created new package.json for @vibe/docs package
  • Defined dependencies on @vibe/core, @vibe/icons, and @vibe/shared
  • Configured Storybook build scripts and dev server
  • Added comprehensive dev dependencies for Storybook, testing, and build
    tools
+163/-0 
preview.tsx
Update Storybook preview configuration paths                         

packages/docs/.storybook/preview.tsx

  • Updated import paths to reflect new directory structure in docs
    package
  • Changed imports from storybook subdirectory to layout and decorators
    directories
  • Updated playground helpers import path
  • Updated welcome page import path
+11/-9   
chromatic.yml
Update Chromatic workflow to docs package                               

.github/workflows/chromatic.yml

  • Changed Chromatic workflow working directory from packages/core to
    packages/docs
+1/-1     
tsconfig.json
Add TypeScript configuration for docs                                       

packages/docs/tsconfig.json

  • Created new TypeScript configuration file for docs package
  • Configured compiler options for ESNext module output and CSS modules
    support
+13/-0   
tsconfig.storybook.json
Add package path mappings to storybook config                       

packages/docs/tsconfig.storybook.json

  • Added path mappings for @vibe/core, @vibe/core/next,
    @vibe/core/interactionsTests, and @vibe/shared
  • Configured TypeScript to resolve packages from core and shared source
    directories
+4/-0     
Formatting
1 files
corner-settings.scss
Update SCSS mixins and remove typography import                   

packages/docs/src/pages/foundations/round-corners/corners-settings/corner-settings.scss

  • Removed import of typography styles
  • Updated SCSS mixins from font-input() to vibe-text(text2, normal)
+2/-3     
Documentation
2 files
storybook-stories.mdc
Update Storybook stories documentation for docs package   

.cursor/rules/storybook-stories.mdc

  • Updated documentation to reflect stories location in packages/docs
    instead of packages/core
  • Changed story file structure guidance to match new docs package
    organization
  • Updated import examples to use @vibe/core package imports
+14/-16 
Loader.mdx
Update Loader documentation with component imports             

packages/docs/src/pages/components/Loader/Loader.mdx

  • Updated component imports to use @vibe/core package
  • Replaced inline HTML with Flex and Heading components
  • Uncommented and enabled use case examples for Loader in text field and
    button
  • Added Tip import from storybook components
+18/-12 
Miscellaneous
3 files
withLiveEdit.tsx
Update LiveEditor import path                                                       

packages/docs/src/decorators/withLiveEdit/withLiveEdit.tsx

  • Updated LiveEditor import path from components to layout directory
+1/-1     
dropdown-migration-guide.mdx
Update migration guide import path                                             

packages/docs/src/pages/components/Dropdown/dropdown-migration-guide.mdx

  • Updated DiffCodeBlock import path to use pages-level migration-guide
    directory
+1/-1     
ModalSideBySideLayout.mdx
Update modal styles import path                                                   

packages/docs/src/pages/components/Modal/ModalSideBySideLayout.mdx

  • Updated modal styles import path to local directory
+1/-1     
Additional files
101 files
file-structures.mdc +0/-3     
naming-conventions.mdc +1/-1     
publish-storybook.yml +2/-2     
package.json +0/-4     
package.json +0/-3     
Loader.stories.tsx +0/-168 
package.json +0/-8     
interactions-helper.ts +0/-6     
index.ts +0/-12   
index.ts +0/-6     
BaseInput.stories.tsx +0/-7     
BaseList.stories.tsx +0/-7     
BaseListItem.stories.tsx +0/-7     
Chips.snapshot.test.tsx +2/-3     
DialogDataTestIds.ts +0/-4     
Dropdown.snapshot.test.jsx +1/-2     
FormattedNumber.stories.scss +0/-4     
formattedNumber.stories.temp +0/-28   
headingTestsConstants.ts +0/-2     
LegacyModal.test.jsx +0/-166 
ListItemAvatar.test.tsx +1/-2     
textTestsConstants.ts +0/-2     
useDisableScroll.mdx +0/-28   
useDisableScroll.stories.tsx +0/-47   
coming-soon.jsx +0/-13   
coming-soon.module.scss +0/-16   
index.ts +0/-5     
README.md +0/-20   
hidden-text-description.tsx +0/-17   
index.ts +0/-2     
art.ts [link]   
manager-head.html [link]   
manager.jsx [link]   
modes.ts [link]   
preview-body.html [link]   
preview-head.html [link]   
storybook-title-fix.js [link]   
theme.js [link]   
tsconfig.json [link]   
chromatic.config.json +1/-1     
withGlobalStyle.module.scss [link]   
withGlobalStyle.tsx [link]   
LiveContent.module.scss [link]   
LiveContent.tsx +2/-5     
LiveContent.types.ts [link]   
LiveEditorAction.module.scss [link]   
LiveEditorAction.tsx [link]   
LiveEditorAction.types.ts [link]   
useApplyDecorators.ts [link]   
useLiveEditorActions.ts [link]   
parse-csf-utils.ts [link]   
prettier-utils.ts [link]   
withLiveEdit.module.scss [link]   
CanvasWrapper.module.scss [link]   
CanvasWrapper.tsx [link]   
ArrowIcon.tsx [link]   
Footer.module.scss [link]   
Footer.tsx +2/-2     
FooterCard.module.scss [link]   
FooterCard.tsx +2/-2     
LiveEditor.tsx [link]   
LivePreview.module.scss [link]   
LivePreview.tsx [link]   
props-table.jsx [link]   
accordion-description.module.scss [link]   
accordion-description.tsx +1/-1     
alert-banner-description.tsx +1/-2     
attention-box-description.jsx +1/-1     
avatar-description.tsx +3/-3     
avatar-group-description.tsx +5/-2     
badge-description.tsx +1/-2     
box-description.tsx +1/-2     
button-description.tsx +1/-1     
button-group-description.tsx +1/-1     
checkbox-description.tsx +1/-1     
chips-description.tsx +1/-1     
clickable-description.stories.module.scss [link]   
clickable-description.tsx +1/-2     
color-picker-description.tsx +1/-1     
colors-description.scss [link]   
colors-description.tsx [link]   
combobox-description.tsx +1/-2     
counter-description.tsx +1/-1     
dialog-content-container.tsx +1/-2     
dialog-description.module.scss [link]   
divider.tsx +1/-3     
dropdown-description.tsx +1/-1     
editable-heading-description.tsx +2/-2     
editable-text-description.tsx +2/-2     
expand-collapse-description.module.scss [link]   
flex-description.tsx +1/-1     
heading-description.tsx +1/-1     
icon-button-description.tsx +1/-1     
icon-description.tsx +1/-1     
icons-description.tsx +1/-1     
label-description.tsx +1/-1     
linear-progress-bar-description.tsx +1/-1     
link-description.tsx +1/-1     
list-description.tsx +1/-3     
ModalBasicLayoutRelatedComponent.tsx +1/-1     
Additional files not shown

@github-actions
Copy link
Contributor

github-actions bot commented Oct 23, 2025

📦 Bundle Size Analysis

✅ No bundle size changes detected.

Unchanged Components
Component Base PR Diff
@vibe/button 17.71KB 17.71KB 0B ➖
@vibe/icon 13.03KB 13.03KB 0B ➖
@vibe/loader 5.81KB 5.81KB 0B ➖
Accordion 6.33KB 6.33KB 0B ➖
AccordionItem 68.16KB 68.16KB 0B ➖
AlertBanner 72.81KB 72.81KB 0B ➖
AlertBannerButton 19.17KB 19.17KB 0B ➖
AlertBannerLink 15.49KB 15.49KB 0B ➖
AlertBannerText 65.41KB 65.41KB 0B ➖
AttentionBox 74.35KB 74.35KB 0B ➖
AttentionBoxLink 15.33KB 15.33KB 0B ➖
Avatar 68.2KB 68.2KB 0B ➖
AvatarGroup 95.67KB 95.67KB 0B ➖
Badge 43.53KB 43.53KB 0B ➖
Box 9.32KB 9.32KB 0B ➖
BreadcrumbItem 66.13KB 66.13KB 0B ➖
BreadcrumbMenu 70.04KB 70.04KB 0B ➖
BreadcrumbMenuItem 79.08KB 79.08KB 0B ➖
BreadcrumbsBar 5.77KB 5.77KB 0B ➖
ButtonGroup 70.22KB 70.22KB 0B ➖
Checkbox 68.46KB 68.46KB 0B ➖
Chips 76.95KB 76.95KB 0B ➖
Clickable 6.25KB 6.25KB 0B ➖
ColorPicker 76.07KB 76.07KB 0B ➖
ColorPickerContent 75.35KB 75.35KB 0B ➖
Combobox 85.84KB 85.84KB 0B ➖
Counter 42.41KB 42.41KB 0B ➖
DatePicker 134.14KB 134.14KB 0B ➖
Dialog 54.05KB 54.05KB 0B ➖
DialogContentContainer 6.32KB 6.32KB 0B ➖
Divider 5.54KB 5.54KB 0B ➖
Dropdown 125.52KB 125.52KB 0B ➖
menu 59.95KB 59.95KB 0B ➖
option 93.08KB 93.08KB 0B ➖
singleValue 93.04KB 93.04KB 0B ➖
EditableHeading 68.08KB 68.08KB 0B ➖
EditableText 68KB 68KB 0B ➖
EmptyState 72.6KB 72.6KB 0B ➖
ExpandCollapse 67.98KB 67.98KB 0B ➖
Flex 7.49KB 7.49KB 0B ➖
FormattedNumber 5.87KB 5.87KB 0B ➖
GridKeyboardNavigationContext 4.65KB 4.65KB 0B ➖
Heading 66.76KB 66.76KB 0B ➖
HiddenText 5.45KB 5.45KB 0B ➖
IconButton 69.97KB 69.97KB 0B ➖
Info 74.14KB 74.14KB 0B ➖
Label 70.34KB 70.34KB 0B ➖
LayerProvider 2.95KB 2.95KB 0B ➖
LegacyModal 76.67KB 76.67KB 0B ➖
LegacyModalContent 66.84KB 66.84KB 0B ➖
LegacyModalFooter 3.45KB 3.45KB 0B ➖
LegacyModalFooterButtons 20.7KB 20.7KB 0B ➖
LegacyModalHeader 72.88KB 72.88KB 0B ➖
Link 15.15KB 15.15KB 0B ➖
List 74.67KB 74.67KB 0B ➖
ListItem 67.43KB 67.43KB 0B ➖
ListItemAvatar 68.48KB 68.48KB 0B ➖
ListItemIcon 14.21KB 14.21KB 0B ➖
ListTitle 66.82KB 66.82KB 0B ➖
Menu 8.67KB 8.67KB 0B ➖
MenuDivider 5.65KB 5.65KB 0B ➖
MenuGridItem 7.22KB 7.22KB 0B ➖
MenuItem 79.05KB 79.05KB 0B ➖
MenuItemButton 72KB 72KB 0B ➖
MenuTitle 67.11KB 67.11KB 0B ➖
MenuButton 67.64KB 67.64KB 0B ➖
MultiStepIndicator 53.32KB 53.32KB 0B ➖
NumberField 74.8KB 74.8KB 0B ➖
LinearProgressBar 7.46KB 7.46KB 0B ➖
RadioButton 67.79KB 67.79KB 0B ➖
Search 72.44KB 72.44KB 0B ➖
Skeleton 6.21KB 6.21KB 0B ➖
Slider 75.79KB 75.79KB 0B ➖
SplitButton 68.65KB 68.65KB 0B ➖
SplitButtonMenu 8.81KB 8.81KB 0B ➖
Steps 73.48KB 73.48KB 0B ➖
Table 7.28KB 7.28KB 0B ➖
TableBody 68.63KB 68.63KB 0B ➖
TableCell 66.95KB 66.95KB 0B ➖
TableContainer 5.34KB 5.34KB 0B ➖
TableHeader 5.7KB 5.7KB 0B ➖
TableHeaderCell 74.09KB 74.09KB 0B ➖
TableRow 5.59KB 5.59KB 0B ➖
TableRowMenu 70.32KB 70.32KB 0B ➖
TableVirtualizedBody 73.33KB 73.33KB 0B ➖
Tab 65.43KB 65.43KB 0B ➖
TabList 8.91KB 8.91KB 0B ➖
TabPanel 5.35KB 5.35KB 0B ➖
TabPanels 5.91KB 5.91KB 0B ➖
TabsContext 5.54KB 5.54KB 0B ➖
Text 66.7KB 66.7KB 0B ➖
TextArea 68.06KB 68.06KB 0B ➖
TextField 71.37KB 71.37KB 0B ➖
TextWithHighlight 65.82KB 65.82KB 0B ➖
ThemeProvider 4.69KB 4.69KB 0B ➖
Tipseen 73.22KB 73.22KB 0B ➖
TipseenContent 73.65KB 73.65KB 0B ➖
TipseenImage 73.57KB 73.57KB 0B ➖
TipseenMedia 73.37KB 73.37KB 0B ➖
TipseenWizard 75.94KB 75.94KB 0B ➖
Toast 76.02KB 76.02KB 0B ➖
ToastButton 19.01KB 19.01KB 0B ➖
ToastLink 15.36KB 15.36KB 0B ➖
Toggle 68.3KB 68.3KB 0B ➖
Tooltip 64.65KB 64.65KB 0B ➖
TransitionView 37.68KB 37.68KB 0B ➖
VirtualizedGrid 12.64KB 12.64KB 0B ➖
VirtualizedList 12.36KB 12.36KB 0B ➖

📊 Summary:

  • Total Base Size: 5.13MB
  • Total PR Size: 5.13MB
  • Total Difference: +0B

@talkor talkor marked this pull request as ready for review October 28, 2025 09:00
@talkor talkor requested a review from a team as a code owner October 28, 2025 09:00
@qodo-merge-for-open-source
Copy link
Contributor

qodo-merge-for-open-source bot commented Oct 28, 2025

PR Reviewer Guide 🔍

(Review updated until commit 6aeace1)

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Possible Flakiness

The new resetFocus clicks an element with data-testid=focusTrap if present. This may intermittently fail if the element isn't rendered yet or multiple traps exist. Consider awaiting canvas queries or adding robustness to avoid race conditions.

export const resetFocus = async () => {
  const focusTrap = document.querySelector("[data-testid=focusTrap]");
  if (focusTrap) {
    await userEvent.click(focusTrap as HTMLElement);
  }
};
Type Safety

Replacing SystemTheme enum usage with string literal "dark" in addAppThemeSuffix reduces type safety. Prefer using the exported SystemTheme type/enum consistently across interactions.

const PRIMARY_COLOR = getVariableHexColor("primary-color");
const POSITIVE_COLOR = getVariableHexColor("positive-color");
const DARK_APP_THEME_CLASS_NAME = addAppThemeSuffix("dark");

async function checkSystemTheme(canvas: Screen) {
Build Config

New path aliases point directly to source files in @vibe/core (e.g., next.ts, index.ts). Ensure these paths work in both dev and build (Vite + Storybook) and won’t desync with package exports. Consider centralizing aliases to avoid drift.

"~monday-ui-style": path.resolve(__dirname, "../../style"),
"~vibe-storybook-components": path.resolve(__dirname, "../../storybook-blocks"),
"@vibe/shared": path.resolve(__dirname, "../../shared/src/index.ts"),
"@vibe/core/interactionsTests": path.resolve(__dirname, "../../core/src/tests/interactions-utils.ts"),
"@vibe/core/next": path.resolve(__dirname, "../../core/src/components/next.ts"),
"@vibe/core": path.resolve(__dirname, "../../core/src/index.ts"),
...components

Copy link
Contributor

@rivka-ungar rivka-ungar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

import { Link, Tip, UsageGuidelines } from "vibe-storybook-components";

enum ThemeColor {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comment, to make sure they stay consistent

@talkor talkor merged commit 16e86ea into master Oct 29, 2025
17 checks passed
@talkor talkor deleted the docs/package branch October 29, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants