chore: change packages to private #3154

talkor · 2025-10-25T16:54:52Z

PR Type

Enhancement, Other

Description

Mark internal packages as private in package.json
Remove circular dependency on @vibe/button from loader
Comment out loader-in-button story and related imports
Resolve circular dependency issue between components

Diagram Walkthrough

flowchart LR
  A["Internal Packages"] -- "mark private" --> B["@vibe/config, @vibe/shared, @vibe/storybook-config"]
  C["Loader Component"] -- "remove dependency" --> D["@vibe/button"]
  D -- "circular dep" --> C
  E["Loader Stories"] -- "comment out" --> F["LoaderInButton story"]

File Walkthrough

Relevant files

Configuration changes

package.json `Mark config package as private` packages/config/package.json Added `"private": true` flag to mark package as internal	+1/-0
package.json `Mark shared package as private` packages/shared/package.json Added `"private": true` flag to mark package as internal	+1/-0
package.json `Mark storybook-config package as private` packages/storybook-config/package.json Added `"private": true` flag to mark package as internal	+1/-0

Dependencies

package.json `Remove button dependency from loader` components/loader/package.json Removed `@vibe/button` from devDependencies to resolve circular dependency	+0/-1

Bug fix

Loader.stories.tsx `Remove button-dependent story and imports` components/loader/src/Loader/stories/Loader.stories.tsx Commented out import of Button component Removed unused React hooks (useCallback, useState) Commented out LoaderInButton story that depends on Button	+16/-16

Documentation

Loader.mdx `Comment out button-related documentation` components/loader/src/Loader/stories/Loader.mdx Commented out "Use cases and examples" section Commented out "Loader in button" subsection and related Canvas component Removed documentation referencing the button integration story	+4/-4

talkor · 2025-10-25T17:24:41Z

components/loader/src/Loader/__stories__/Loader.mdx

 />

-## Use cases and examples
+{/* ## Use cases and examples */}


Will revert in a different PR

github-actions · 2025-10-25T17:26:43Z

📦 Bundle Size Analysis

✅ No bundle size changes detected.

Unchanged Components

Component	Base	PR	Diff
`Accordion`	6.35KB	6.35KB	0B ➖
`AccordionItem`	68.09KB	68.09KB	0B ➖
`AlertBanner`	72.82KB	72.82KB	0B ➖
`AlertBannerButton`	19.16KB	19.16KB	0B ➖
`AlertBannerLink`	15.51KB	15.51KB	0B ➖
`AlertBannerText`	65.35KB	65.35KB	0B ➖
`AttentionBox`	74.26KB	74.26KB	0B ➖
`AttentionBoxLink`	15.36KB	15.36KB	0B ➖
`Avatar`	68.27KB	68.27KB	0B ➖
`AvatarGroup`	95.82KB	95.82KB	0B ➖
`Badge`	43.55KB	43.55KB	0B ➖
`Box`	9.31KB	9.31KB	0B ➖
`BreadcrumbItem`	66.12KB	66.12KB	0B ➖
`BreadcrumbMenu`	70.15KB	70.15KB	0B ➖
`BreadcrumbMenuItem`	79.05KB	79.05KB	0B ➖
`BreadcrumbsBar`	5.76KB	5.76KB	0B ➖
`ButtonGroup`	70.27KB	70.27KB	0B ➖
`Checkbox`	68.46KB	68.46KB	0B ➖
`Chips`	77.04KB	77.04KB	0B ➖
`Clickable`	6.27KB	6.27KB	0B ➖
`ColorPicker`	76.04KB	76.04KB	0B ➖
`ColorPickerContent`	75.41KB	75.41KB	0B ➖
`Combobox`	85.9KB	85.9KB	0B ➖
`Counter`	42.45KB	42.45KB	0B ➖
`DatePicker`	134.38KB	134.38KB	0B ➖
`Dialog`	54.04KB	54.04KB	0B ➖
`DialogContentContainer`	6.3KB	6.3KB	0B ➖
`Divider`	5.54KB	5.54KB	0B ➖
`Dropdown`	125.42KB	125.42KB	0B ➖
`menu`	59.93KB	59.93KB	0B ➖
`option`	93.11KB	93.11KB	0B ➖
`singleValue`	93.04KB	93.04KB	0B ➖
`EditableHeading`	68.16KB	68.16KB	0B ➖
`EditableText`	68.04KB	68.04KB	0B ➖
`EmptyState`	72.65KB	72.65KB	0B ➖
`ExpandCollapse`	67.94KB	67.94KB	0B ➖
`Flex`	7.46KB	7.46KB	0B ➖
`FormattedNumber`	5.87KB	5.87KB	0B ➖
`GridKeyboardNavigationContext`	4.65KB	4.65KB	0B ➖
`Heading`	66.81KB	66.81KB	0B ➖
`HiddenText`	5.41KB	5.41KB	0B ➖
`IconButton`	69.91KB	69.91KB	0B ➖
`Info`	74.15KB	74.15KB	0B ➖
`Label`	70.33KB	70.33KB	0B ➖
`LayerProvider`	2.95KB	2.95KB	0B ➖
`LegacyModal`	76.66KB	76.66KB	0B ➖
`LegacyModalContent`	66.91KB	66.91KB	0B ➖
`LegacyModalFooter`	3.47KB	3.47KB	0B ➖
`LegacyModalFooterButtons`	20.73KB	20.73KB	0B ➖
`LegacyModalHeader`	72.83KB	72.83KB	0B ➖
`Link`	15.15KB	15.15KB	0B ➖
`List`	74.67KB	74.67KB	0B ➖
`ListItem`	67.42KB	67.42KB	0B ➖
`ListItemAvatar`	68.43KB	68.43KB	0B ➖
`ListItemIcon`	14.17KB	14.17KB	0B ➖
`ListTitle`	66.84KB	66.84KB	0B ➖
`Menu`	8.66KB	8.66KB	0B ➖
`MenuDivider`	5.66KB	5.66KB	0B ➖
`MenuGridItem`	7.22KB	7.22KB	0B ➖
`MenuItem`	78.94KB	78.94KB	0B ➖
`MenuItemButton`	72.07KB	72.07KB	0B ➖
`MenuTitle`	67.15KB	67.15KB	0B ➖
`MenuButton`	67.68KB	67.68KB	0B ➖
`MultiStepIndicator`	53.33KB	53.33KB	0B ➖
`NumberField`	74.91KB	74.91KB	0B ➖
`LinearProgressBar`	7.42KB	7.42KB	0B ➖
`RadioButton`	67.65KB	67.65KB	0B ➖
`Search`	72.41KB	72.41KB	0B ➖
`Skeleton`	6.2KB	6.2KB	0B ➖
`Slider`	75.83KB	75.83KB	0B ➖
`SplitButton`	68.65KB	68.65KB	0B ➖
`SplitButtonMenu`	8.82KB	8.82KB	0B ➖
`Steps`	73.5KB	73.5KB	0B ➖
`Table`	7.32KB	7.32KB	0B ➖
`TableBody`	68.67KB	68.67KB	0B ➖
`TableCell`	66.93KB	66.93KB	0B ➖
`TableContainer`	5.38KB	5.38KB	0B ➖
`TableHeader`	5.7KB	5.7KB	0B ➖
`TableHeaderCell`	74.11KB	74.11KB	0B ➖
`TableRow`	5.58KB	5.58KB	0B ➖
`TableRowMenu`	70.39KB	70.39KB	0B ➖
`TableVirtualizedBody`	73.24KB	73.24KB	0B ➖
`Tab`	65.48KB	65.48KB	0B ➖
`TabList`	8.92KB	8.92KB	0B ➖
`TabPanel`	5.36KB	5.36KB	0B ➖
`TabPanels`	5.91KB	5.91KB	0B ➖
`TabsContext`	5.54KB	5.54KB	0B ➖
`Text`	66.64KB	66.64KB	0B ➖
`TextArea`	68.07KB	68.07KB	0B ➖
`TextField`	71.22KB	71.22KB	0B ➖
`TextWithHighlight`	65.79KB	65.79KB	0B ➖
`ThemeProvider`	4.69KB	4.69KB	0B ➖
`Tipseen`	73.18KB	73.18KB	0B ➖
`TipseenContent`	73.72KB	73.72KB	0B ➖
`TipseenImage`	73.45KB	73.45KB	0B ➖
`TipseenMedia`	73.28KB	73.28KB	0B ➖
`TipseenWizard`	75.85KB	75.85KB	0B ➖
`Toast`	76.06KB	76.06KB	0B ➖
`ToastButton`	19.03KB	19.03KB	0B ➖
`ToastLink`	15.36KB	15.36KB	0B ➖
`Toggle`	68.36KB	68.36KB	0B ➖
`Tooltip`	64.68KB	64.68KB	0B ➖
`TransitionView`	37.65KB	37.65KB	0B ➖
`VirtualizedGrid`	12.58KB	12.58KB	0B ➖
`VirtualizedList`	12.34KB	12.34KB	0B ➖

📊 Summary:

Total Base Size: 5.09MB
Total PR Size: 5.09MB
Total Difference: +0B

qodo-merge-for-open-source · 2025-10-25T17:28:42Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Orphaned docs The "Related components" still references `Button` while the Loader-in-Button story is commented out; ensure docs do not mislead users or reference unavailable examples. ## Related components <RelatedComponents componentsNames={["Skeleton", "LinearProgressBar", "Button"]} /> Build/Storybook impact Removing `@vibe/button` from devDependencies may affect Storybook stories or local development; verify no remaining imports/usages and Storybook still runs. "devDependencies": { "@testing-library/react": "^12.1.2", "@vibe/config": "3.0.1", "react": "^16.13.0", "react-dom": "^16.13.0", "react-test-renderer": "16",

talkor added 2 commits October 25, 2025 19:43

chore: change packages to private

4179188

chore: temp solve circular dep

e29862a

talkor commented Oct 25, 2025

View reviewed changes

talkor marked this pull request as ready for review October 25, 2025 17:28

talkor requested a review from a team as a code owner October 25, 2025 17:28

talkor changed the title ~~chore: change packages to private~~ chore: change internal packages to private Oct 25, 2025

qodo-merge-for-open-source bot changed the title ~~chore: change internal packages to private~~ chore: change packages to private Oct 25, 2025

qodo-merge-for-open-source bot added the Review effort 2/5 label Oct 25, 2025

talkor merged commit 090499e into master Oct 25, 2025
17 checks passed

talkor deleted the chore/internal-packages branch October 25, 2025 17:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: change packages to private #3154

chore: change packages to private #3154

Uh oh!

talkor commented Oct 25, 2025 •

edited by qodo-merge-for-open-source bot

Loading

Uh oh!

talkor Oct 25, 2025

Uh oh!

github-actions bot commented Oct 25, 2025

Uh oh!

qodo-merge-for-open-source bot commented Oct 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chore: change packages to private #3154

chore: change packages to private #3154

Uh oh!

Conversation

talkor commented Oct 25, 2025 • edited by qodo-merge-for-open-source bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Type

Description

Diagram Walkthrough

File Walkthrough

Uh oh!

talkor Oct 25, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 25, 2025

Uh oh!

qodo-merge-for-open-source bot commented Oct 25, 2025

PR Reviewer Guide 🔍

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

talkor commented Oct 25, 2025 •

edited by qodo-merge-for-open-source bot

Loading